pull-request icon indicating copy to clipboard operation
pull-request copied to clipboard

fix: remove quotes from reviewer for team reviewer support

Open payton opened this issue 4 years ago • 3 comments

Hub supports team reviewers. It depends on the "/" to differentiate a user from a team. However, when we quote the reviewer, it's assumed to be a user.

This changes allows us to tag user and team reviewers.

payton avatar Feb 12 '21 15:02 payton

This would be better suited for most other input variables, too.

I'm not sure how much processing is preferred, but I can add a quick bash function to remove any whitespace within the input as per the hub docs: A comma-separated list (no spaces around the comma)

payton avatar Feb 12 '21 16:02 payton

Hi @payton thanks for your contribution.

I tried running the command locally and in GitHub Actions and was not able to reproduce. I did notice the team has to be given access to the repo first before the endpoint will add team reviewers. With or without quotes didn't make a different in the end result. Could you double check on your end? Thanks!

wei avatar Feb 15 '21 16:02 wei

Hey @wei . Thanks for checking. Yeah, I'll go through it again just in case.

payton avatar Feb 15 '21 16:02 payton