troubleshoot icon indicating copy to clipboard operation
troubleshoot copied to clipboard

Multiple runPod specs with the same name overwrite each other's data

Open xavpaice opened this issue 2 years ago • 2 comments

Bug Description

If two or more collector specs include the runPod collector with the same name, the second one to run will overwrite the data from the first.

Although it's not possible right now, if two run at the same time, with the same pod name, there will be a collision.

Expected Behavior

Each collector has a unique data output.

Each runPod collector starts a pod with a unique name.

Steps To Reproduce

Include the following in a spec:

apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
  name: sample
spec:
  collectors:
    - runPod:
        name: "run-ping"
        namespace: default
        podSpec: 
          containers:
          - name: run-ping
            image: busybox:1
            command: ["ping"]
            args: ["-w", "5", "www.google.com"]
    - runPod:
        name: "run-ping"
        namespace: default
        podSpec: 
          containers:
          - name: run-ping
            image: busybox:1
            command: ["ping"]
            args: ["-w", "5", "www.reddit.com"]

There may be other collectors that have the same problem, we have merely identified this with runPod at this point in time.

Additional Context

Include the following information.

  • Troubleshoot version. If you built from source, note that including the version of Go you used to build with.

0.49.1

xavpaice avatar Dec 09 '22 04:12 xavpaice

@diamonwiggins I'm adding you as assignee here because of your PR - hope that's OK!

xavpaice avatar Dec 21 '22 00:12 xavpaice

The PR introduces a change which changes the path for runPod collector output. This is required to resolve the issue, however it's a breaking change and we do not have data on how many analyzers this might break.

Let's progress with the following:

  • #963
  • Collect data about how much usage there is of textAnalyze combined with runPod
  • From that data, determine if the breaking change is significant.

xavpaice avatar Jan 13 '23 04:01 xavpaice