troubleshoot icon indicating copy to clipboard operation
troubleshoot copied to clipboard

fix: allow passing empty namespace again for clusterResources

Open dkoshkin opened this issue 4 years ago • 1 comments

A recent commit broke previous behavior of being able to collect clusterResources: {} from all namespaces.

From the docs

This will attempt to collect information from all namespaces

Tested with:

apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
metadata:
  name: namespace-bug
spec:
  collectors:
    - clusterInfo: {}
    - clusterResources: {}

Ran it with this fix (see output snippet):

➜ tree support-bundle-2021-08-12T16_45_04/cluster-resources
support-bundle-2021-08-12T16_45_04/cluster-resources
├── deployments
│   ├── calico-system.json
│   ├── default.json
│   ├── kube-node-lease.json
│   ├── kube-public.json
│   ├── kube-system.json
│   ├── node-feature-discovery.json
│   └── tigera-operator.json

And with latest release

➜ ./support-bundle version
Replicated Troubleshoot 0.13.7
➜  tree support-bundle-2021-08-12T16_46_11/cluster-resources/
support-bundle-2021-08-12T16_46_11/cluster-resources/
├── deployments
│   └── default.json

dkoshkin avatar Aug 12 '21 23:08 dkoshkin

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 12 '21 23:08 CLAassistant

This has been over a year since submission, and I see that there are now several similar fixes in place already (though, not for the clusterResources collector).

I'll close this out now, if the issue is still current we should raise a clear bug and it's a simpler fix than this one.

xavpaice avatar Aug 30 '22 06:08 xavpaice