troubleshoot icon indicating copy to clipboard operation
troubleshoot copied to clipboard

remove golangci-lint from CI

Open adamancini opened this issue 1 year ago • 1 comments

from Marc:

org wide, we are not recommending or using golangci-lint. we’ve removed it from CMX and Vandoor

golangci-lint does add additional checks fwiw, but we seem to be disabling and ignoring most of them (and rightly so IMO, they aren’t providing a TON of value. for example, we have 100s of errors that we are ignoring a return value from a call. after looking at all of them (literally all of them in vendor-api), they all would be replaced with _ = While that’s more exact and specific, it not really making the product or code better. And, i’d argue, that the Go language was pretty intentionally written to produce predictable code at Google. You can’t include an import that’s not used, you can’t have unused variables. Why did they make it ok to ignore errors when you choose? (I think it’s because it’s normal, and you should make that decision)

adamancini avatar Oct 25 '24 14:10 adamancini