Easer icon indicating copy to clipboard operation
Easer copied to clipboard

Fixed issue where profiles were changing operation type on save

Open bitskeptic opened this issue 3 years ago • 1 comments

Fixed issue #409 - Profiles created with "Send Broadcast" or "Start Service" operation type revert to "Start Activity" on save. This was occurring because all intent profiles used the IntentOperationData data type and LocalSkillRegistry used this data type to match the profile with a skill. All intent profiles would match against all intent skills, so the first intent skill in the list (which was ActivityOperationSkill) would always be assigned to every intent data type. To fix this issue, new data types were created for all the intent operation skills. Associated DataFactory and SkillViewFragment classes were created as well. The IntentOperationDataTest was also updated. A intent operation utility class was created to house some shared code.

bitskeptic avatar Dec 04 '21 15:12 bitskeptic

Thanks for the PR! Apologise for not responding earlier.

(As mentioned in #401) Is this PR also for #401? If so, there seems to be some conflicts / repeated efforts in trying to fix this: Later down in #401, a commit 17556cab083234050767efc48b6b7510fe056224 should fix that issue.

renyuneyun avatar Mar 27 '22 20:03 renyuneyun