php-k8s icon indicating copy to clipboard operation
php-k8s copied to clipboard

Replace deprecated package

Open leo108 opened this issue 2 years ago • 8 comments

vierbergenlars/php-semver has been deprecated and can be replaced by composer/semver.

Also add the missing json ext requirement.

leo108 avatar May 20 '23 04:05 leo108

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.11%. Comparing base (5d9d356) to head (4929c19).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #351      +/-   ##
============================================
+ Coverage     94.17%   95.11%   +0.93%     
- Complexity      700      701       +1     
============================================
  Files            70       70              
  Lines          1837     1841       +4     
============================================
+ Hits           1730     1751      +21     
+ Misses          107       90      -17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '23 04:05 codecov[bot]

@rennokki any chance to check this pr?

leo108 avatar May 25 '23 07:05 leo108

@rennokki bump

leo108 avatar Jun 17 '23 13:06 leo108

@rennokki Sorry but I want to bump it again, please take a look when you have time

leo108 avatar Jul 24 '23 12:07 leo108

cc @rennokki pls :)

ro0NL avatar Aug 03 '23 14:08 ro0NL

I don't know how I missed this PR. I have another variant of it here:

https://github.com/renoki-co/php-k8s/pull/380

I can trim off my commit and just keep the other bumps if we favor this one... I can also merge this commit over into mine to consolidate as well.

Great work!

cuppett avatar Aug 31 '23 14:08 cuppett

@rennokki Sorry to bother you again, but I'm really hope this PR can be merged, please let me know what you concern, thanks!

leo108 avatar Dec 02 '23 02:12 leo108

It's almost one year later...

Bump again @rennokki

leo108 avatar Mar 25 '24 16:03 leo108