php-k8s
php-k8s copied to clipboard
Replace deprecated package
vierbergenlars/php-semver has been deprecated and can be replaced by composer/semver.
Also add the missing json ext requirement.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.11%. Comparing base (
5d9d356) to head (4929c19).
Additional details and impacted files
@@ Coverage Diff @@
## master #351 +/- ##
============================================
+ Coverage 94.17% 95.11% +0.93%
- Complexity 700 701 +1
============================================
Files 70 70
Lines 1837 1841 +4
============================================
+ Hits 1730 1751 +21
+ Misses 107 90 -17
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rennokki any chance to check this pr?
@rennokki bump
@rennokki Sorry but I want to bump it again, please take a look when you have time
cc @rennokki pls :)
I don't know how I missed this PR. I have another variant of it here:
https://github.com/renoki-co/php-k8s/pull/380
I can trim off my commit and just keep the other bumps if we favor this one... I can also merge this commit over into mine to consolidate as well.
Great work!
@rennokki Sorry to bother you again, but I'm really hope this PR can be merged, please let me know what you concern, thanks!
It's almost one year later...
Bump again @rennokki