renode-infrastructure icon indicating copy to clipboard operation
renode-infrastructure copied to clipboard

TimeHandle: Initialize TotalElapsedTime to NearestSyncPoint

Open sean-anderson-seco opened this issue 8 months ago • 1 comments

When registering a new TimeHandle, IsReadyForNewTimeGrant will be true. However, other handles may have already been granted time. The TimeSource will wait for these other active handles to finish (causing their TotalElapsedTime to increase). After all all active handles have finished, SynchronizeVirtualTime will attempt to update the TimeSource's ElapsedVirtualTime. However, the newly-added handle's TotalElapsedTime will still be the source's ElapsedVirtualTime from when the handle was added. This will prevent time from advancing. This will cause ExecuteSyncPhase to fail, since ElapsedVirtualTime will not equal NearestSyncPoint.

Fix this by initializing TimeHandle.TotalElapsedTime to TimeSource.NearestSyncPoint, which is the earliest time that time will be granted to the handle.

Fixes: 49d06a36 ("[#8661] Introduce new time framework.")

sean-anderson-seco avatar Mar 11 '25 20:03 sean-anderson-seco

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sean Anderson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 11 '25 20:03 CLAassistant