Feature/basename

[yracnet]

trafficstars

I have implemented the feature described on the https://github.com/remix-run/remix/discussions/2891.

This include the serverBasename attribute on remix.config.js for declare a prefix to URL

serverBasename default value is "" fix deploy on path server (basename) fix the navegation in client side or server side components

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 28fd0a1be33c4565288f9e20b2da168648064817

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot[bot]]

Hi @yracnet,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot[bot]]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[machour]

Refs #2996

[gerbyzation]

This would be a great feature to have in remix. If I can help with making this happen let me know!

[yracnet]

Thanks, but I dont know what is the next step.

[gerbyzation]

@yracnet As mentioned in this comment I think they are waiting for some unrelated changes that have snuck in to be removed: https://github.com/remix-run/remix/pull/4459#pullrequestreview-1162370075 For example decisions/0006-linear-workflow.md is added as part of this PR but doesn't seem related to the scope?

[hemangsk]

@yracnet , First of all great job, this is such a useful feature.

Do I have your permission to fork this branch and do the required changes (removing unrelated commits) and make the PR merge ready? We really need this feature and incase you're busy, I'll be more than willing to get things moving here 🙏

[yracnet]

Hi @hemangsk thanks, I have merged my branch with the las change from dev, I run the test. I will wait to approval my changes. thanks

[gerbyzation]

@yracnet thanks for updating your branch! Unfortunately there are still unrelated changes in the diff. As @hemangsk and I have offered we're happy to port your work to a clean branch to get this shipped if you don't mind

[yracnet]

Thanks, I will send a new pr with the clean branch from dev.

[yracnet]

clean branch to https://github.com/remix-run/remix/pull/5236