react-router icon indicating copy to clipboard operation
react-router copied to clipboard

feat(router): add type safety to `json` & `redirect` functions

Open MichaelDeBoey opened this issue 3 years ago • 1 comments

This PR brings these functions in line with what we have in the Remix repo

MichaelDeBoey avatar Dec 03 '22 00:12 MichaelDeBoey

⚠️ No Changeset found

Latest commit: 07917876cca85e8d7ba7abb57126d41c59162a95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 03 '22 00:12 changeset-bot[bot]

I think we may want to close this and let https://github.com/remix-run/react-router/discussions/9854 handle all data-typings together?

brophdawg11 avatar Jan 09 '23 23:01 brophdawg11

oh I see you have a separate PR for useLoaderData too. I linked to that from the proposal, once that gets accepted maybe we can just run with these PRs then!

brophdawg11 avatar Jan 09 '23 23:01 brophdawg11

Doing some housecleaning to start 2023 so I'm going to lose these 2 PRs out until the proposal gets accepted and we can re-open or bring along the changes then 👍

brophdawg11 avatar Jan 19 '23 19:01 brophdawg11

Re-opening because @brophdawg11 started with https://github.com/remix-run/remix/pull/5679

MichaelDeBoey avatar Mar 06 '23 20:03 MichaelDeBoey

Let's hold on this for a bit longer, we have some APIs coming in Remix v3 (which will come through RR) that may or may not make these typings obsolete :). But at the very least we should wait to make sure that anything we do for typings on these functions plays nicely with the upcoming v3 APIs

brophdawg11 avatar Apr 18 '23 13:04 brophdawg11

Closing for now - will re-open if/when we want to add these 👍

brophdawg11 avatar May 25 '23 17:05 brophdawg11