react-router icon indicating copy to clipboard operation
react-router copied to clipboard

[Bug]: the image on the line 10 of the tutorial page is broken

Open nykhylsharma opened this issue 3 years ago • 2 comments

What version of React Router are you using?

Latest

Steps to Reproduce

Go to link https://github.com/remix-run/react-router/blob/main/docs/start/tutorial.md Check the image on line 10

Expected Behavior

The image shouldn't be broken

Actual Behavior

The image on #10 of https://github.com/remix-run/react-router/blob/main/docs/start/tutorial.md is broken

nykhylsharma avatar Nov 17 '22 17:11 nykhylsharma

Hi @nykhylsharma, that documentation is meant to be read from this page https://reactrouter.com/en/main/start/tutorial, not on GitHub

machour avatar Nov 17 '22 17:11 machour

Hi Mehdi,

Thanks for sharing the URL. In this case, the tutorial URL on React Router's readme page(https://github.com/remix-run/react-router) should point to it. It points to https://github.com/remix-run/react-router/blob/main/docs/start/tutorial.md instead

On Thu, Nov 17, 2022 at 10:55 PM Mehdi Achour @.***> wrote:

Closed #9607 https://github.com/remix-run/react-router/issues/9607 as not planned.

— Reply to this email directly, view it on GitHub https://github.com/remix-run/react-router/issues/9607#event-7836140169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWE5MOWASWAP2EUUOFOYYTWIZTAPANCNFSM6AAAAAASDTCZKY . You are receiving this because you were mentioned.Message ID: @.***>

nykhylsharma avatar Nov 17 '22 18:11 nykhylsharma

Also, the link on https://www.npmjs.com/package/react-router-dom also points to https://github.com/remix-run/react-router/blob/main/docs/start/tutorial.md

Jagholin avatar Dec 15 '22 09:12 Jagholin

That is the intended link.

timdorr avatar Dec 15 '22 15:12 timdorr

What's going on with the web site? I'm getting an error screen. I had to use Wayback Machine to go back to Dec 22nd to view the site.

ghost avatar Jan 01 '23 21:01 ghost