react-router icon indicating copy to clipboard operation
react-router copied to clipboard

fixed createURL() for Firefox

Open AchThomas opened this issue 3 years ago • 3 comments

window.location.origin is "null" (the literal string value) in Firefox under certain conditions: https://bugzilla.mozilla.org/show_bug.cgi?id=878297

This leads to a broken app in Firefox when you build for production and try to use it from the local file system in an HTML file.

I added an additional check in createURL() in router.ts to respect that case.

AchThomas avatar Oct 14 '22 13:10 AchThomas

⚠️ No Changeset found

Latest commit: ce4ef8bf3d7e131fbc07445906f8a2ab4a372989

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 14 '22 13:10 changeset-bot[bot]

Hi @AchThomas,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Oct 14 '22 13:10 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Oct 14 '22 13:10 remix-cla-bot[bot]

Thanks!

brophdawg11 avatar Oct 24 '22 21:10 brophdawg11

@AchThomas This is available in 6.4.3-pre.1 if you want to confirm that it's working!

brophdawg11 avatar Oct 25 '22 22:10 brophdawg11