react-router fix: ensure consistency in generatePath/compilePath for partial splats

fix: ensure consistency in generatePath/compilePath for partial splats

Open brophdawg11 opened this issue 3 years ago • 1 comments

~~This fixes a small inconsistency in generatePath w.r.t. compilePath. We do support partial named params but at the moment we do not support partial splat params, but generatePath was permitting them. This aligns generatePath behavior and provides the same warning as compilePath~~

After chatting with @ryanflorence we decided that if possible we should look into removing that warning and supporting partial splat params (in path matching and generatePath), such the the path /prefix-* is matched by the URL /prefix-thing. This PR adds specific scoring for both partial dynamic (/prefix-:param) and partial static (/prefix-*) path segments.

There are I think 2 exiting unit tests that break, that rely on the behavior indicated by the previous warning. So want to confirm those changes with @mjackson and @ryanflorence, but otherwise everything else passes and I added a decently sized test to try to really kick the tire son the scoring algorithm and potential conflicts.

Note: Recommend viewing the PR with whitespace hidden