react-router icon indicating copy to clipboard operation
react-router copied to clipboard

fix: context memoization

Open mohd-akram opened this issue 3 years ago • 6 comments

Without this, anything that used useLocation (including Routes) was constantly re-rendering.

mohd-akram avatar Sep 07 '22 13:09 mohd-akram

🦋 Changeset detected

Latest commit: 282b1033415fd24b0e1cf42a9b3bbdbbeada1c88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 07 '22 13:09 changeset-bot[bot]

Hi @mohd-akram,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Sep 07 '22 13:09 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Sep 07 '22 13:09 remix-cla-bot[bot]

Is this good to merge?

mohd-akram avatar Sep 14 '22 10:09 mohd-akram

Folks, this issue is causing noticeable lag in our application after upgrading from v5. Hope it can be released in the next update.

mohd-akram avatar Oct 03 '22 07:10 mohd-akram

Yes please!!! this is causing some many issues for us

JClackett avatar Dec 08 '22 13:12 JClackett