react-router
react-router copied to clipboard
bug-report - param containing double encoded characters should not be double decoded by useParams
It seems parameters which are encoded using encodeURIComponent are automatically decoded when using useParams or matchPath.
So if I encode them twice, I expect them to be encoded once, after calling useParams. However, it seems like there is something special with forward slash (/). It is fully decoded after getting it with useParams, whereas matchPath works as expected.
⚠️ No Changeset found
Latest commit: 9b855abf6abbc2c70389490a10fb86b0e803ab2c
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi @qtoden,
Welcome, and thank you for contributing to React Router!
Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.
You may review the CLA and sign it by adding your name to contributors.yml.
Once the CLA is signed, the CLA Signed label will be added to the pull request.
If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].
Thanks!
- The Remix team
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳
Seems very related to https://github.com/remix-run/react-router/issues/11293