react-router icon indicating copy to clipboard operation
react-router copied to clipboard

fix(react-router-serve): ensure node_env set before react loaded

Open jrestall opened this issue 1 year ago • 3 comments

Fixes #12078.

Error only reproducible with React v19 but even with React v18 the dev react and prod react-dom modules are loaded, it just doesn't hard error.

jrestall avatar Oct 26 '24 02:10 jrestall

Hi @jrestall,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Oct 26 '24 02:10 remix-cla-bot[bot]

⚠️ No Changeset found

Latest commit: 87a1b2bca2a8e07ce76abfc0fec51d36cc2c1777

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 26 '24 02:10 changeset-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Oct 26 '24 02:10 remix-cla-bot[bot]

Thank you for this PR! I'm working on a similar issue with prerendering in React 19 so I cherry-picked these over to https://github.com/remix-run/react-router/pull/12505 and will get the fix in via that PR.

brophdawg11 avatar Dec 09 '24 20:12 brophdawg11