react-router icon indicating copy to clipboard operation
react-router copied to clipboard

fix(react-router): (v7) fix static prerender non-ascii problem

Open saengmotmi opened this issue 1 year ago • 3 comments

fix #12160

  • Fixed an issue where builds would fail during static prerendering in React Router v7 when the data passed to the loader contains non-ASCII characters, such as Korean.
  • Applied encodeURI to the X-React-Router-Prerender-Data header when making requests to localhost in the loader, and added decodeURI processing on the receiving end.
  • Added relevant tests and confirmed that they pass.

Screenshot 1: Attempted static prerendering, which failed.

image

Screenshot 2: Used console.log to inspect the requestInit object inside prerenderRoute to identify the point where prerendering fails.

image

Screenshot 3: Confirmed that the non-ASCII data is correctly passed to the loader after applying encodeURI/decodeURI.

image

saengmotmi avatar Oct 20 '24 14:10 saengmotmi

🦋 Changeset detected

Latest commit: 33a0c0dfdffc3c8432be934cd703dc7ffa0f9711

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 20 '24 14:10 changeset-bot[bot]

Hi @saengmotmi,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Oct 20 '24 14:10 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Oct 20 '24 14:10 remix-cla-bot[bot]

Hello @timdorr,

It looks like only the msedge runner failed, while firefox and webkit passed without any issues. Since there were no relevant changes to the code, it might just be an intermittent runner issue. Would you mind re-running the tests?

Thank you!


(it's fine in my local)

image

saengmotmi avatar Nov 02 '24 03:11 saengmotmi

Thank you @saengmotmi for the contribution!

jacob-ebey avatar Nov 12 '24 23:11 jacob-ebey

🤖 Hello there,

We just published version 7.0.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Nov 22 '24 07:11 github-actions[bot]

🤖 Hello there,

We just published version 6.28.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Dec 18 '24 16:12 github-actions[bot]

🤖 Hello there,

We just published version 6.28.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Dec 20 '24 20:12 github-actions[bot]

🤖 Hello there,

We just published version 7.1.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Dec 20 '24 22:12 github-actions[bot]

🤖 Hello there,

We just published version 6.28.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jan 14 '25 16:01 github-actions[bot]