react-router icon indicating copy to clipboard operation
react-router copied to clipboard

fix: preserve state when location prop changes

Open gnapse opened this issue 1 year ago • 4 comments

Fixes https://github.com/remix-run/react-router/issues/11902

gnapse avatar Aug 16 '24 16:08 gnapse

⚠️ No Changeset found

Latest commit: a1bd035cd23ee4d32104bbf01f5ecf63f5e9e805

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 16 '24 16:08 changeset-bot[bot]

Hi @gnapse,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Aug 16 '24 16:08 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Aug 16 '24 16:08 remix-cla-bot[bot]

@MichaelDeBoey (just because I do not know who else to ping and I saw you active at reviewing other PRs in this repository)

Any chance I can get some feedback on this PR and/or the issue it is aiming to fix? (#11902)

gnapse avatar Oct 14 '24 17:10 gnapse