react-router
react-router copied to clipboard
chore: fix some comments
⚠️ No Changeset found
Latest commit: 4f7399c5b6aa7110c0dd3f1bd22f2c4d77f3018e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi @pwdcd,
Welcome, and thank you for contributing to React Router!
Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.
You may review the CLA and sign it by adding your name to contributors.yml.
Once the CLA is signed, the CLA Signed label will be added to the pull request.
If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].
Thanks!
- The Remix team
Thank you! Would you mind signing the CLA so we can get this merged?
Thank you! Would you mind signing the CLA so we can get this merged?
Of course. Signed.
Please review again
You need to add your username to the contributors.yml file. That is how we track signatures.
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳
You need to add your username to the contributors.yml file. That is how we track signatures.
Sorry it took so long to process. The conflict has been resolved and the username has been added to the contributors.yml file.
Please review again.
Tanks!
🤖 Hello there,
We just published version 7.1.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!
Thanks!
🤖 Hello there,
We just published version 6.28.3-pre-v6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!
Thanks!
bad bot - this is definitely not in 6.28.3-pre-v6.0 😂 . It looks like something about our logic for identifying included issues doesn't work for our v6 releases from the v6 branch so I'm going to disable this commenting for v6 releases going forward