react-router icon indicating copy to clipboard operation
react-router copied to clipboard

Fix support for optional static segments

Open LadyTsukiko opened this issue 1 year ago • 2 comments

Added support and tests for optional static segments in matchPath. According to the docs they should be supported but were not.

Before the fix the pattern "/user/admin?" would match "/user/admi" and "/user/admin" but not "/user".

LadyTsukiko avatar Jul 17 '24 08:07 LadyTsukiko

🦋 Changeset detected

Latest commit: e6ea20f0208588725183203508dc50082451c237

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jul 17 '24 08:07 changeset-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Jul 17 '24 08:07 remix-cla-bot[bot]

🤖 Hello there,

We just published version 7.8.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Aug 07 '25 16:08 github-actions[bot]

🤖 bad bot - this is not in 7.8.0 and will be in the next release

brophdawg11 avatar Aug 07 '25 17:08 brophdawg11

🤖 Hello there,

We just published version 7.8.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Aug 14 '25 14:08 github-actions[bot]

🤖 Hello there,

We just published version 7.8.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Aug 15 '25 19:08 github-actions[bot]