Generic for useLocation to allow to provide type for Location State

[arajg0909]

The current implementation of useLocation does not allow for state type to be passed as a generic to Location return type. By just passing a simple generic we can safely type the state from the location.

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 28cb78accc1c459743814c9800a1c762d0da417f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot[bot]]

Hi @arajg0909,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot[bot]]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[timdorr]

This has been suggested many times.

This would actually remove type safety, as you would be overriding state to that type. You should be using type narrowing to determine the type of state safely. A generic would be a hack to force that to work.

https://github.com/remix-run/react-router/pull/8370#issuecomment-974578233 https://github.com/remix-run/react-router/issues/8396#issuecomment-980829670

[arajg0909]

Thanks @timdorr. You are right !