react-router icon indicating copy to clipboard operation
react-router copied to clipboard

fix: Wait for restore url navigation to complete before proceeding

Open Artur- opened this issue 1 year ago • 6 comments

Fixes #11613

Artur- avatar Jun 06 '24 06:06 Artur-

🦋 Changeset detected

Latest commit: 6071fb15312f247ffd52355bc3fcaa8e05c62c00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/remix-v2-routes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 06 '24 06:06 changeset-bot[bot]

Hi @Artur-,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Jun 06 '24 06:06 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Jun 06 '24 06:06 remix-cla-bot[bot]

Not exactly sure why the tests need an additional 10ms wait for the state to the updated now

Artur- avatar Jun 06 '24 08:06 Artur-

Any chance of getting this reviewed and into v6?

Artur- avatar Jun 11 '24 08:06 Artur-

@brophdawg11?

Artur- avatar Jun 17 '24 08:06 Artur-

The test in https://github.com/remix-run/react-router/pull/11620/commits/82d43447f9a5cf8e81d232530502914d86fe643a is for this case and fails in the dev branch

Artur- avatar Jul 23 '24 16:07 Artur-

@markdalgleish any comment on this? Is there a way to get this moving forward instead of collecting dust and conflicts?

Artur- avatar Jul 31 '24 07:07 Artur-

Superseded by #11930

brophdawg11 avatar Aug 26 '24 18:08 brophdawg11