react-router
react-router copied to clipboard
fix: Wait for restore url navigation to complete before proceeding
Fixes #11613
🦋 Changeset detected
Latest commit: 6071fb15312f247ffd52355bc3fcaa8e05c62c00
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 9 packages
| Name | Type |
|---|---|
| react-router | Patch |
| @react-router/architect | Patch |
| @react-router/cloudflare | Patch |
| @react-router/dev | Patch |
| react-router-dom | Patch |
| @react-router/express | Patch |
| @react-router/node | Patch |
| @react-router/serve | Patch |
| @react-router/remix-v2-routes | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Hi @Artur-,
Welcome, and thank you for contributing to React Router!
Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.
You may review the CLA and sign it by adding your name to contributors.yml.
Once the CLA is signed, the CLA Signed label will be added to the pull request.
If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].
Thanks!
- The Remix team
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳
Not exactly sure why the tests need an additional 10ms wait for the state to the updated now
Any chance of getting this reviewed and into v6?
@brophdawg11?
The test in https://github.com/remix-run/react-router/pull/11620/commits/82d43447f9a5cf8e81d232530502914d86fe643a is for this case and fails in the dev branch
@markdalgleish any comment on this? Is there a way to get this moving forward instead of collecting dust and conflicts?
Superseded by #11930