[Bug]: isBrowser false when no document.createElement

[mateusvahl]

What version of React Router are you using?

6.22.2

Steps to Reproduce

I'm running react-router-dom in Shopify customer account ui environment

This runs on a webworker with a subset javascript API and no access to DOM APIs.

When using useFetcher() , the submit action was throwing an error saying:

router.fetch() was called during the server render, but it shouldn't be. You are likely calling a useFetcher() method in the body of your component. Try moving it to a useEffect or a callback.

After further investigation in the source code, I notice it was related to to isBrowser detection, which expects window.document.createElement !== "undefined" (false in my environment).

A workaround was define createElement before initialise the route, which fixes the detection.

self.document.createElement = () => {  /** empty **/ };

Let me me know if any additional details is needed.

Expected Behavior

isBrowser should not really on window.document.createElement

Actual Behavior

window.document.createElement is undefined, leading isBrowser to be considered false.

[mateusvahl]

This seems to be fixed by https://github.com/remix-run/react-router/pull/11544, however, it seems that react-router-dom still checks for a window variable and fails if it does not exists.

If you are using Shopify customer accounts, you can fix it by:

self.window = {};

(Remember that window is not accessible in Shopify customer account/webworker, so we "simulate" its presence).

It seems that there's very few places in the source code that uses window, we could probably fix it by using self