react-router
react-router copied to clipboard
remix-run
HashRouter hashType option. Compatibility with v4/v5
During migration from v4/v5 to v6 I've found that hashType is not implemented in newer version. This is an issue since there is a whole instruction on migration. I cannot change the type of encoding in project that this is applicable to. I've raised an issue quite some time ago, but misspelled the prop name, hence the issue was closed. Looking forward to resolve any of my errors and I'd love to see this merged/released asap. Thanks in advance
Hi @Whaileee,
Welcome, and thank you for contributing to React Router!
Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.
You may review the CLA and sign it by adding your name to contributors.yml.
Once the CLA is signed, the CLA Signed label will be added to the pull request.
If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].
Thanks!
- The Remix team
![remix-cla-bot[bot] avatar](https://avatars.githubusercontent.com/u/64235328?v=4 "Published by a pub.dev verified publisher"){kind=small}
🦋 Changeset detected
Latest commit: 3d0c1b3a6a756bc0333df498c86fc79cdb4fa8b2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 8 packages
| Name | Type |
|---|---|
| react-router | Patch |
| react-router-dom | Patch |
| @react-router/architect | Patch |
| @react-router/cloudflare | Patch |
| @react-router/dev | Patch |
| @react-router/express | Patch |
| @react-router/node | Patch |
| @react-router/serve | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳
Check for bundle size already fixed. I'm still having some issues with this failing test. This test seems to pass for node >= 18. Not sure why v16 is not working. Also I noticed that when 2 of 3 of these test functions are present it passes, no matter which. Also for some reason, the order seems to matter. I would really appreciate any suggestion.
seems like --runInBand solves this problem, but I don't think that's the preferred solution