fix: memoize useFetchers

[jacobparis]

useFetchers currently returns a new array on every render. This PR memoizes it based on the internal useDataRouterState which appears to be stable as long as the fetchers aren't actually changing.

The included test fails before the fix with fetchers count: 3 and passes after the fix

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 5f5d91e7a13d1f1b834f06b762122b35a0db28d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot[bot]]

Hi @jacobparis,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot[bot]]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[brophdawg11]

Thanks for this PR - I forgot to go back and look at the implementation. I don't actually think this was stable before - it was always a new array instance .

I agree it probably should be but I need to take a bit of a closer look to ensure that we're guaranteeing a brand new Map on state.fetchers every time we update a single fetcher 👍

[jacobparis]

Admittedly I didn't dig through the history to see if it used to be

Instead my expected behaviour was based on this tweet from @ryanflorence https://twitter.com/ryanflorence/status/1746281296475943243?s=46&t=9QWqc33eA_iECT8wUUL0VA

[brophdawg11]

Ah - yeah that tweet's referring to useFetcher - which is correctly memoized. useFetchers probably should be too though - I was just checking to see if this was a regression or just something we hadn't yet tackled 👍

[brophdawg11]

At a quick glance, I think we always do a new Map when we set fetchers - but I'm slightly concerned that we mutate in place to update fetchers prior to setting the new Map. I think I'd like to update the router to always do the new Map up front and then mutate and commit it - so that we never mutate state.fetchers in the first place. I'll try to tackle that soon 👍