html-react-parser icon indicating copy to clipboard operation
html-react-parser copied to clipboard

Published 20 hours ago β€’ verified publisher icon remarkablemark

#625: <option> tag should also be valueOnly

Open philiptzou opened this issue 3 years ago β€’ 4 comments

Fixes #625

Checklist:

philiptzou avatar Jul 11 '22 00:07 philiptzou

Codecov Report

Merging #628 (829de65) into master (d7ba9d7) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #628   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          167       167           
  Branches        57        57           
=========================================
  Hits           167       167
Impacted Files Coverage Ξ”
lib/attributes-to-props.js 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update d7ba9d7...829de65. Read the comment docs.

codecov-commenter avatar Jul 11 '22 01:07 codecov-commenter

@remarkablemark I think this may need more works since I didn't test it. I'll work on this tomorrow.

philiptzou avatar Jul 11 '22 02:07 philiptzou

@remarkablemark I think this may need more works since I didn't test it. I'll work on this tomorrow.

Sounds good πŸ‘

remarkablemark avatar Jul 11 '22 02:07 remarkablemark

Hey @philiptzou, were you able to make any progress? Let me know if you need any help

remarkablemark avatar Jul 30 '22 18:07 remarkablemark