Wrapping some extra components inside of the Context Menu Component

[tgberkeley]

For the context menu we have not wrapped some of the components.

We wrap the context menu here in the code: https://github.com/reflex-dev/reflex/blob/main/reflex/components/radix/themes/components/context_menu.py and we want to add these other sub-components mentioned above with all their props and event handlers.

• [ ] Label
• [ ] Group
• [ ] RadioGroup
• [ ] RadioItem
• [x] CheckboxItem

[linear[bot]]

ENG-4022 Wrapping some extra components inside of the Context Menu Component

[LucasOcampos]

Hey @tgberkeley! I would love to contribute to Reflex, the link that the linear bot posted is not opening up for me though. Is this task still available?

[Lendemor]

The link posted by the linear bot doesn't have additional info, it's just there for tracking in our private linear. Since the task is still open, it's available yes.

[LucasOcampos]

Awesome, if you could set me as assignee for this task please, I'd appreciate it!

[KarinaNi]

Hi @tgberkeley and @Lendemor if possible I would love to be assigned to this issue. I have got the project locally working and have an idea of how to wrap these components. If this is available, please assign it to me.

[vydpnguyen]

Hi @tgberkeley and @KarinaNi, I would love to collaborate with you two and take over the CheckboxItem part.

[Lendemor]

Updated the initial post with a checklist for the missing components. @LucasOcampos @vydpnguyen @KarinaNi feel free to pick up any of the components in there and submit them.

The PR for the checkbox seems to works, we just need the others now 👍

[KarinaNi]

Hi, I can do radiogroup and radio item.

[vydpnguyen]

Hi @KarinaNi, how are the RadioGroup and RadioItem going for you? I've finished the CheckBoxItem part.

[KarinaNi]

Hi, I shall try to finish it by today. I added all items so ill just commit the radio ones so give me a bit of time so i finish that

[KarinaNi]

update: finished making the changes in code. Trying to get all success in the tests

poetry run ruff check .
poetry run pyright reflex tests
find reflex tests -name "*.py" -not -path reflex/reflex.py | xargs poetry run darglint

currently getting errors related to navbar, table etc in pyright reflex tests

[Lendemor]

update: finished making the changes in code. Trying to get all success in the tests

poetry run ruff check .
poetry run pyright reflex tests
find reflex tests -name "*.py" -not -path reflex/reflex.py | xargs poetry run darglint

currently getting errors related to navbar, table etc in pyright reflex tests

You should pip install pre-commit then pre-commit install If you are just adding new components it should not break any of the existing tests.

[KarinaNi]

After doing that, I seem to get more errors than before (422errors, 2 warning) Python version - 3.11.0

any idea what could be causing it and how to fix it?

[KarinaNi]

Hi, any update on this would be highly appreciate. I really like this project and would love to contribute more

[Lendemor]

If you get so many errors it's possible you have a version of pyright that is too recent compared to the one being used on Reflex.

We're working on updating to latest pyright so soon it shouldn't be a problem anymore.

[Lendemor]

Also, even if it's a work in progress, feel free to open a PR/ Draft PR so we can actually look at the change you made and test them locally, it'll be easier for any team member to help you 👍

[sumanth-dhanya]

@Lendemor i have created a pull request Wrapping extra components inside of the Context Menu Component #4831. Do let me know any additional changes required .