⚠️ Features broken on new issues (beta)

[fregante]

trafficstars

Description

I'm sure every isConversationList feature is currently broken on that page.

How to replicate the issue + URL

Test URLs:

• https://github.com/download-directory/download-directory.github.io/issues/141
• https://github.com/eslint/eslint/issues
• https://github.com/tc39/proposal-await.ops/issues

The beta is enabled by organization. These three have it. You can spam issues on https://github.com/download-directory/download-directory.github.io/issues if necessary, I'll delete them once we're done. Or leave comments in https://github.com/download-directory/download-directory.github.io/issues/141, better.

[fregante]

By the way, finally we have an autocomplete!

[fregante]

Bye quick-comment-hiding

[fregante]

These are features running on isIssueList and isSingleIssue

I'll check these off after verifying them, or with 👋 if they're no longer needed

Important features

• [ ] https://github.com/refined-github/refined-github/issues/8024
• [ ] #7968
• [ ] https://github.com/refined-github/refined-github/issues/8226
• [ ] close-as-unplanned (see below)
• [x] comments-time-machine-links
• [ ] https://github.com/refined-github/refined-github/issues/8586
• [ ] expand-all-hidden-comments
• [ ] hide-low-quality-comments

Rest

• [x] readable-title-change-events
• [ ] https://github.com/refined-github/refined-github/issues/8263
• [ ] hide-navigation-hover-highlight
• [ ] keyboard-navigation
• [ ] linkify-user-edit-history-popup
• [x] linkify-user-location
• [ ] preview-hidden-comments
• [ ] quick-mention
• [x] selection-in-new-tab
• [x] shorten-links
• [ ] toggle-everything-with-alt

Done

Edit February 6th: Some of these have been broken again. Please open a new issue in that case.

• [x] jump-to-conversation-close-event
• [x] show-names
• [x] small-user-avatars
• [x] sticky-sidebar
• [x] table-input
• [x] reactions-avatars
• [x] scrollable-areas
• [x] prevent-link-loss
• [x] collapsible-content-button
• [x] embed-gist-inline
• [x] emphasize-draft-pr-label
• [x] linkify-user-labels
• [x] jump-to-conversation-close-event
• [ ] avoid-accidental-submissions 👋
• [ ] esc-to-cancel 👋
• [ ] clean-conversation-headers 👋
• [ ] prevent-comment-loss 👋
• [ ] quick-comment-hiding 👋
• [x] bugs-tab
• [x] ci-link
• [x] clean-repo-tabs
• [x] clean-rich-text-editor
• [x] close-out-of-view-modals
• [x] command-palette-navigation-shortcuts
• [x] copy-on-y
• [x] esc-to-deselect-line
• [x] fit-textareas
• [x] hide-diff-signs
• [x] hide-user-forks
• [x] improve-shortcut-help
• [x] linkify-branch-references
• [x] linkify-code
• [x] linkify-line-numbers
• [x] more-dropdown-links
• [x] one-key-formatting
• [x] parse-backticks
• [x] profile-hotkey
• [x] quick-comment-edit
• [x] quick-new-issue
• [x] releases-tab
• [x] reload-failed-proxied-images
• [x] repo-avatars
• [x] repo-header-info
• [x] repo-wide-file-finder
• [x] show-whitespace
• [x] sort-conversations-by-update-time
• [x] tab-to-indent
• [x] unfinished-comments
• [x] user-local-time

[fregante]

The list above has already been verified. Unless you see that the feature is no longer needed, you can assume they're not working. That would save time from having to build that table

[kovsu]

Here has two avatar.

https://github.com/download-directory/download-directory.github.io/issues?q=is%3Apr

[fregante]

cc @ToBinio https://github.com/refined-github/refined-github/pull/7924

[ToBinio]

@fregante could it be that GitHub is rolling out that feature? cause for is:pr it also renders images without refined Github

should I open a PR and just fix it for is:pr or do you think it will come for normal issues too and the feature should just be disabled for the new view

[fregante]

Uh, they did 😅

[fregante]

• preview-hidden-comments

We should hold off on implementing this one, their header layout is messy on mobile and I expect them to change it completely. Only fix it if it's a simple class change

[fregante]

For advanced features like close-as-unplanned, we have to use the UI on behalf of the user because we no longer have the good ol' form element 😒

For example in https://github.com/refined-github/refined-github/pull/7893 this meant opening the dropdown menu and simulating a click on the Edit item.

Here I'd expect the dropdown arrow to be hidden and a new custom button to be added. When the button is clicked, we show the arrow, open it, click "close as not planned", then click the new "close" button.

I wonder if it's just easier to do it via API and call triggerConversationUpdate (which is also likely broken on the new issue view), but I think that as long as every part here is selectable, it's actually not too difficult:

https://github.com/refined-github/refined-github/blob/60217e812c4bac4707d1f1b6caea6fd10a0d672e/source/features/quick-comment-edit.tsx#L25-L33

[darkred]

Today's blog post announces the gradual rollout of the new issue view to everyone, with all users expected to have access by the end of this week:

https://github.blog/changelog/2025-01-13-evolving-github-issues-public-preview/

Following our opt-in preview last year, we are excited to release sub-issues, issue types and advanced search for issues to everyone! 🎉

Thank you to everyone who opted-in and gave us feedback on these new additions. We will be rolling out these changes incrementally and expect all users to have access by the end of this week.

[fregante]

Oof. We still have a few broken important features. It would be good to address them this week so that it's easy to preserve GHE compat. If not, PRs are not affected yet so that view can be used as "old" for now.

@kovsu do you see anything that you can address? I think the "activity filter" and "clean sidebar" are the most pressing. Others might need a "simple" selector update.

[kidonng]

table-input needs CSS update:

[injust]

I think comments-time-machine-links might need changes for the new issues.

If I comment this:

@injust testing

And then Quote reply, I get this:

> [@injust](https://github.com/injust?rgh-link-date=2025-01-17T10%3A58%3A26.000Z) testing

I don't think the rgh-link-date parameter is supposed to appear there, right?

Might be similar to https://github.com/refined-github/refined-github/issues/8218.

[mathomp4]

I was going to make a "The new Bug issue type doesn't trigger bugs-tab" issue, but I suppose that would be this issue? Unless you'd prefer a separate issue for tracking purposes?

[fregante]

New issue, that would be a feature request

[kovsu]

quick-mention needs to be updated. It doesn't work now.

[Xelbayria]

Has the broken "collapsible-content-button" been resolved? I can't use it as is.

[kovsu]

@Xelbayria It's working. If you still have any problem please open an issue to provide more details.

[SunsetTechuila]

note on preview-hidden-comments: comment body ('[class^="IssueCommentViewer-module__IssueCommentBody"]') is removed from the DOM when the comment is hidden, so we have to either get the data from the react props or by using api

[fregante]

If it's missing from the DOM, let's hold off on fixing that feature. Most likely we'll just have to drop it once every view is broken (the feature still works on PRs for now)

[SunsetTechuila]

we'll just have to drop it

are you against of extracting data from react props?

[fregante]

I think we do it in a couple of features but those props are not reliable, meaning they're not always there. I don't want bug reports for a feature that works half the time.

As for calling the API… we could do it, but we have to see if it's worth it. So far nobody even reported that it's been broken.

[SunsetTechuila]

those props are not reliable

maybe this issue is not the place for this discussion, but how are they less reliable than dom elements? also, it seems that with github updates, relying on dom will become less and less feasible

[fregante]

DOM is "unreliable" in a different way: always there today, but tomorrow it may change.

React props, if we're talking about the same thing, suffer from the same problem AND one more: they're already not always there. Meaning: GitHub may inject those on a page reload, but not when navigating via Ajax.

[SunsetTechuila]

does a pr that uses react props have a chance to be merged if it works?

[fregante]

There are more useful features that I'd rather see, like #8226 or even the similar expand-all-hidden-comments

[0xdevalias]

I'm not sure if this is a refined-github bug, or just a GitHub bug (and haven't got the capacity to check deeper at the moment, so wanted to note it here in case), but today I tried to use the 'Close as duplicate' on an issue I opened, but a repo I don't have permissions on.

I didn't end up selecting another issue to link it to as it was on another repo.

It looked like everything worked and closed the issue properly; but then when I did a full refresh / reload / checked the issue list later; I realised that it didn't actually close the issue at all.

---

Edit: I just tried to replicate this now and I couldn't.. and checking a different issue it did actually close it as a duplicate properly.. so maybe it was my error.

[SunsetTechuila]

also, it seems that with github updates, relying on dom will become less and less feasible

The same is true for reusing existing elements. Most of the time, we can simply clone and edit them, but not always. Plus, this could be tedious, so I would like to link my comment here: https://github.com/refined-github/refined-github/pull/8712#discussion_r2499138687

Writing this more for future reference than to discuss