system24
system24 copied to clipboard
fix issues from #32
#32
should also fix #16
more issues pointed out here https://github.com/refact0r/system24/issues/32#issuecomment-2413494860 , this pr isn't dead i'm just a little busy recently ^^ will continue working when i have time
most of what i've done seem to have been fixed in the actual repo at this point ^^ i can close the pr if that'd be preferred
up to you
i think this is ready for review now, i did quite a bit so i lumped most of what i added in a section at the bottom of main.css
can you clarify which of the original issues this fixes exactly? it seems like most of them no longer exist in the current version of the theme.
- color tab underlines (eg. "user profiles"/"server profiles" in profile settings)
- status bubble coloring (fixed in upstream now)
- modal coloring (fixed in upstream now)
- make theme work better in light mode (fixed in upstream, i think? i still have some issues when using upstream in light mode though)
- remove shadow on forum posts in grid view
- color some things in channel search popups (eg. the date picker) (still some things here i haven't figured out how to color)
- color placeholder text (eg. "where would you like to go?"
- color audio controls
- a lot of coloring on the call box & buttons, think most of them are fixed in upstream now
- color the arrows on call buttons (ie. on the camera and mute buttons)
- color embed titles(?) (ie. channel name in youtube embeds)
- change the selector on the "input" title thing so it doesn't show up when searching for forum posts
- add a bottom margin to forum thread banners (eg. "this post has been locked") so it doesn't overlap with the "messages" title
this should be most of it, a lot of my changes are to color variables that affect a lot of things. also many of them are just things i noticed or that were pointed out in the discord server
see the images i posted above. it seems like the some of the changes in this pr will break some older fixes. you probably have to rebase or merge from the main branch.
ya dis fixes alot of stuff :3 gud job all u guys :3
thank you thank you! will get around to rebasing again soon :')
my only issue anywhere is custom profile bgs are hard to read if they are bright
the text should look alright if you turn on sync profile themes in settings