redux-devtools icon indicating copy to clipboard operation
redux-devtools copied to clipboard

Avoid auto-selecting instance in iFrames

Open alexandcote opened this issue 1 year ago • 3 comments

Note: First time contributing to this project, open to feedback

Avoid auto-selecting the outer frame instance when redux exists in iFrame embedded on the page.

Fix: #1000

iFrame has a different tabID than the main frame. The connections are therefore not grouped properly.

Example:

{
  "connections": {
    "<tabId>" ["<firstConnectionID>"],
    "<iFrameTabId>": ["<secondConnectionID>"]
  }
}

Should we group those connections under the same key? The fix is working but I'm unsure if it's the right solution to the problem.

alexandcote avatar Jun 21 '24 20:06 alexandcote

🦋 Changeset detected

Latest commit: d03eb599a8a525b928a42a226f5d5543ad33167e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
remotedev-redux-devtools-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 21 '24 20:06 changeset-bot[bot]

Hello @Methuselah96, sorry to ping you directly. I would love to finally fix this issue. Let me know if you would like me to use a different approach or tweak anything.

Thanks for you time

alexandcote avatar Jul 30 '24 18:07 alexandcote

Hello @alexandcote, sorry for the lack of response so far. I've been digging into the code that controls auto-selection since some of it is related to upgrading to Manifest V3. As part of that investigation, I believe I've found a fix for this bug and I expect it will be included in the next release, which I hope to put out in the next few weeks.

Sorry it has taken so long to get to this, but I hope this will be fixed soon.

Methuselah96 avatar Jul 30 '24 19:07 Methuselah96