redux-devtools icon indicating copy to clipboard operation
redux-devtools copied to clipboard

Adds argument to prevent Redux DevTool CLI disconnecting when debugging

Open jardicc opened this issue 1 year ago • 2 comments

Adds new CLI argument to change pingTimeout value. This solves few issues for me if I set crazy high number.

  1. UXP in Photoshop has UWP implementation of WebSockets and its client when asked to send empty message it is never sent but everything else is. Thefore it gets disconnected. https://github.com/reduxjs/redux-devtools/issues/1614

  2. I think for some older middleware using protocol V1 sending different ping content this could help as well https://github.com/zalmoxisus/remote-redux-devtools/issues/158

  3. When you debug client app and you stop on breakpoint for 20s which default value of socket cluster... it will disconnect debugger as well because you stopped client app so it can't send a ping. So value can be increased to prevent that.

Also maxRequestBody was wrong.

Please let me know if I should change something or feel free to change it yourself. I was thinking about seconds instead of ms but not sure what is better.

jardicc avatar Mar 04 '24 20:03 jardicc

⚠️ No Changeset found

Latest commit: ef3f1c558d56cba25b8cdfb2125c4f2c8061409f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 04 '24 20:03 changeset-bot[bot]

Can someone please review this PR?

jardicc avatar Sep 06 '24 14:09 jardicc