redux-devtools icon indicating copy to clipboard operation
redux-devtools copied to clipboard

Fix ReduxDevtools to work in Sizzy

Open Zeko369 opened this issue 3 years ago • 1 comments

Sizzy is an electron powered browser that mocks UserAgent to match the simulated device, so ReduxDevtools can't detect it as Electron.

Sizzy does however expose a global __sizzy attribute with which we can detect it's running in Sizzy

Zeko369 avatar Jun 23 '22 21:06 Zeko369

⚠️ No Changeset found

Latest commit: 0abf95987b96e0ee200e84fb99b07e074463ba17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 23 '22 21:06 changeset-bot[bot]

Is this still an issue? It would be nice if Redux DevTools didn't have to know about Sizzy, and it seemed like maybe that was being worked on by Sizzy.

Methuselah96 avatar Oct 29 '22 19:10 Methuselah96

It is still an issue yes.

If this PR is the best solution I couldn't say but IMO I see this in the same way as the isFirefox but it's not my call to make.

francisprovost avatar Oct 31 '22 19:10 francisprovost

Fixed upstream in Sizzy

Zeko369 avatar Apr 07 '23 13:04 Zeko369