react-redux
react-redux copied to clipboard
Add `size-limit` config
This PR:
- [X] Adds
size-limitconfig to monitor bundle size changes in preparation for any potential changes we'll have to make to migrate to React 19.
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Honestly, I'm not a huge fan of these sorts of tools. They tend to be more annoying than helpful. Maybe we can limit it to just a react19 branch, so we don't have to tend to it after we complete that work?
Edit: Wait, don't we already have this? https://github.com/reduxjs/react-redux/blob/master/.github/workflows/size.yaml
@timdorr
Honestly, I'm not a huge fan of these sorts of tools. They tend to be more annoying than helpful.
That's fair, but size-limit does give us an idea of how the changes that we make impact our bundle sizes. And with the way I setup the config, it can keep track of every single named export, in every single package entry point, in both development and production builds. And the config is simple enough that I hope we'd be able to insert into any one of the redux packages and it should just work.
Edit: Wait, don't we already have this? https://github.com/reduxjs/react-redux/blob/master/.github/workflows/size.yaml
While preactjs/compressed-size-action does give us some info about bundle size changes, it looks like it's only looking at dist/cjs/index.js and dist/react-redux.legacy-esm.js. It also doesn't look at named exports, or different environments.
The idea is to have this here so that if we were ever to make a set of changes, we could use it to keep an eye on bundle sizes, it doesn't necessarily have to put a "limit" on anything.
yeah, while I don't think the concept of a size "limit" is very useful, I do find it useful to have visibility on how a given set of changes affects final bundle size.
Could this supplant our usage of compressed-size-action? That one hasn't been updated in a long time and causes some warnings in CI that will eventually turn into errors, so it's been on my radar to replace it.
I guess we could use https://github.com/EskiMojo14/size-limit-action, same thing we're doing with RTK.
Deploy Preview for react-redux-docs ready!
| Name | Link |
|---|---|
| Latest commit | bdaffcd9e1630bf1274a713687bbde95f29817a4 |
| Latest deploy log | https://app.netlify.com/sites/react-redux-docs/deploys/66bfddc6a1b3d600086c804a |
| Deploy Preview | https://deploy-preview-2173--react-redux-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Yeah, I think we want to switch to the other size package for consistency.
The other size package?
https://github.com/EskiMojo14/size-limit-action , per above
Note: The action is failing because we don't have size-limit on master. Once this lands, that error goes away.
Can we just merge this at this point? I don't need another resolution for 2025 😂
@aryaemami59 same question as with the RTK PR - what does the actual output look like atm?