redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard

Publish runtime metric in seconds

Open VladLazar opened this issue 3 years ago • 0 comments

Note: Depends on https://github.com/redpanda-data/seastar/pull/31.

Cover letter

This PR adds the following new metric: Name: redpanda_scheduler_runtime_seconds Description: Accumulated runtime of task queue associated with this scheduling group Labels:

  • redpanda_scheduling_group
  • shard

Backport Required

  • [X] not a bug fix
  • [ ] papercut/not impactful enough to backport
  • [ ] v22.2.x
  • [ ] v22.1.x
  • [ ] v21.11.x

UX changes

  • none

Release notes

  • none

VladLazar avatar Aug 08 '22 12:08 VladLazar

I don't think the sum of these is the same as vectorized_reactor_cpu_busy_ms. So maybe we should add redpanda_cpu_busy_seconds_total?

BenPope avatar Aug 10 '22 18:08 BenPope

No, it's not. I think the "busy time" includes the wait time too. Sure, we can add it. It's already exposed by the reactor.

VladLazar avatar Aug 11 '22 09:08 VladLazar

Changes in force push:

  • publish scheduler stats from the default group too
  • added redpanda_application_uptime_seconds_total and redpanda_application_busy_seconds_total

VladLazar avatar Aug 11 '22 10:08 VladLazar

I set this for backport to v22.2.x

BenPope avatar Aug 11 '22 13:08 BenPope

Awesome.

I built and tested this locally

Appreciate that. Thanks for trying!

VladLazar avatar Aug 11 '22 16:08 VladLazar

/backport v22.2.x

BenPope avatar Aug 11 '22 16:08 BenPope