Dmitry Repchevsky

Results 46 comments of Dmitry Repchevsky
trafficstars

This a conceptual discrepancy. Michael and me had a long conversation and see the spec. differently. ```json "filteringTerms": [ { "id": "NCIT:C20197", "label": "Male", "resources": [ { "id": "NCIT", "iriPrefix":...

>deleting the filteringTerms.yaml filteringTerms.yaml is a reference implementation thing. The question is should we remove /filtering_terms endpoints from endpoints? https://github.com/ga4gh-beacon/beacon-v2/blob/d2be0e2fcc4cbbaebb355caaf8a20af25504a687/models/json/beacon-v2-default-model/individuals/endpoints.json#L152 (or this was an error from the beginning?). Will "filteringTermsUrl"...

I'm for the "A". the rationale: 1. one single place for filters (simplifies things, especially in the BN). 2. endpoints for entry types kept free from auxiliary stuff.

Hi all, This is the problem of polymorphic types definition in JSON schema. [genomicVariations endpoint](https://github.com/ga4gh-beacon/beacon-v2/blob/d2be0e2fcc4cbbaebb355caaf8a20af25504a687/models/json/beacon-v2-default-model/genomicVariations/endpoints.json#L267) points to the "common" parameters which is just [JSON Object](https://github.com/ga4gh-beacon/beacon-v2/blob/main/framework/json/requests/requestParameters.json) We have (syntactically erroneous) [requestParameters.json](https://github.com/ga4gh-beacon/beacon-v2/blob/main/models/json/beacon-v2-default-model/genomicVariations/requestParameters.json)...

https://datatracker.ietf.org/doc/html/rfc6570 uri-template is an URI "with variables" - it is as in the name - a template to produce the URI. Technically any URI should be a valid template with...

> Thank you @redmitry . So, are we still willing to accept this PR? Or can we close it? IMO this should be in the main branch.

Not critical bug correction. Draft 7 validators should fail validating `"singleEntryUrl": "https://beacons.bsc.es/beacon/v2.0.0/datasets/{id}"` because "{}" characters forbidden in URI. On the other hand in 2020-12 "format" property shouldn't be considered by...

> @redmitry @datsirul any answer to my question above? The point is that the current schema is wrong. Should be either: ```json "aCollectionOf": { "description": "If the entry...", "type": "object",...

> IMU, the second one will be a breaking change while the first one is not (THIS is the important thing to me). Am I right? No. The current schema...

> I don't know if it's better to put it as an object or not, what I see is that if we don't specify all the cases in which we...