redis
redis copied to clipboard
redis
Cleanup around FAST command flag
We have many fast O(1) commands that are not marked as FAST, causing them to end up being marked as SLOW. (If it's not fast is slow in this binary world.)
This will affect the ACL, but i am not sure what anyone is doing with it. And this will affect the redis-doc, people get confused when they see a simple command flagged with SLOW.
I may have missed something or misjudged something. It is really difficult to define whether some commands are FAST or SLOW. Push the current commit first (i am a bit tired now)
Would it be more economical to flag the SLOW commands and have everything else be FAST by default?
Would it be more economical to flag the SLOW commands and have everything else be FAST by default?
yes, i think that will be.
In other words, i'm also wondering if we need an intermediate state, some commands can be fast or can be slow depending the args (such as COUNT).
Would it be more economical to flag the SLOW commands and have everything else be FAST by default?
yes, i think that will be.
In other words, i'm also wondering if we need an intermediate state, some commands can be fast or can be slow depending the args (such as COUNT).
Maybe we should have FAST for the commands that are always fast and SLOW for commands that are always slow. For other commads we don't need any of these flags.
So maybe we don't want not FAST to imply SLOW?
Maybe we should have FAST for the commands that are always fast and SLOW for commands that are always slow. For other commads we don't need any of these flags. So maybe we don't want not FAST to imply SLOW?
i like this idea, but it depends on how it is promoted later. It is actually more like a cleanup. It is not very profitable, but it is afraid of introducing other problems.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
