redis-rb icon indicating copy to clipboard operation
redis-rb copied to clipboard

Published 20 hours ago • verified publisher icon redis

Fix reutrning in subscription callbacks cause race condition

Open kazzix14 opened this issue 3 years ago • 3 comments

This PR fixes #1065

kazzix14 avatar Feb 04 '22 17:02 kazzix14

Could you produce a test case for this? It's really a fairly sensitive thing, so I'm not really willing to change this without proper test coverage on it.

byroot avatar Feb 05 '22 10:02 byroot

Thank you for reviewing! I'll add tests for this PR when I have time. could you please wait for it?

kazzix14 avatar Feb 07 '22 17:02 kazzix14

I wrote a test, but I'm not sure it is enough. Please teach me if there are other test cases that we should cover.

kazzix14 avatar Apr 14 '22 15:04 kazzix14

Closing as stale. The bug should be solved in 5.x already.

byroot avatar Nov 24 '22 19:11 byroot