redis-py icon indicating copy to clipboard operation
redis-py copied to clipboard

Adding Async Tests

Open shacharPash opened this issue 2 years ago • 3 comments
trafficstars

Pull Request check-list

Please make sure to review and check all of these items:

  • [ ] Does $ tox pass with this change (including linting)?
  • [ ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [ ] Is the new or changed code fully tested?
  • [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [ ] Is there an example added to the examples folder (if applicable)?
  • [ ] Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

shacharPash avatar Mar 21 '23 15:03 shacharPash

Codecov Report

Patch coverage: 83.87% and project coverage change: -0.01 :warning:

Comparison is base (d95d8a2) 92.26% compared to head (4fea98b) 92.25%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2635      +/-   ##
==========================================
- Coverage   92.26%   92.25%   -0.01%     
==========================================
  Files         116      116              
  Lines       30217    30244      +27     
==========================================
+ Hits        27879    27902      +23     
- Misses       2338     2342       +4     
Impacted Files Coverage Δ
tests/test_asyncio/test_commands.py 97.39% <83.87%> (-0.21%) :arrow_down:

... and 4 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Mar 22 '23 15:03 codecov-commenter

@shacharPash still relevant?

chayim avatar Jun 08 '23 09:06 chayim

This pull request is marked stale. It will be closed in 30 days if it is not updated.

github-actions[bot] avatar Jun 08 '24 00:06 github-actions[bot]