redis-doc icon indicating copy to clipboard operation
redis-doc copied to clipboard

Published 20 hours ago • verified publisher icon redis

Latency trouble shooting

Open pizhenwei opened this issue 3 years ago • 9 comments

Add document for latency trouble shooting:

  • Add 'disable-thp' into latency.md, reference redis change.
  • Document 'Latency induced by reading smaps/smaps_rollup', reference atop change.
  • Introduce tcprtt to trace TCP latency,

pizhenwei avatar Aug 04 '22 01:08 pizhenwei

Deploy request for redis-doc pending review.

Visit the deploys page to approve it

Name Link
Latest commit 22882a83d3719b2c98442032b3a05b1b9fc28d04

netlify[bot] avatar Aug 04 '22 01:08 netlify[bot]

Hello @pizhenwei

Thanks for this contribution. Before reviewing it thoroughly, I'd like to understand why this should be included in the docs instead of other perf tools/metrics/etc.

@filipecosta90 please feel free to jump in

itamarhaber avatar Aug 06 '22 13:08 itamarhaber

Hi @itamarhaber

I read docs from redis.io, followed the 'Edit this page' button, and added these changes in this PR. It's the first time I've tried to contribute to redis doc, if anything gets wrong, please correct me, thanks!

pizhenwei avatar Aug 07 '22 02:08 pizhenwei

Hi @itamarhaber Could you please give me any hint, should I move any documents into another document or directory?

pizhenwei avatar Aug 10 '22 03:08 pizhenwei

@itamarhaber PING!

pizhenwei avatar Aug 16 '22 06:08 pizhenwei

+PONG nothing is wrong with the contribution (thanks and congrats on your first!) per se. I'm not a performance engineer/admin so I'm having difficulties evaluating these tips. I'm also wondering whether there are other, perhaps even more useful, tips that we want to include. Therefore my question :)

@filipecosta90 thoughts?

itamarhaber avatar Aug 16 '22 12:08 itamarhaber

@filipecosta90 PING!

Hi, I edited the top comment and added link.

pizhenwei avatar Aug 24 '22 06:08 pizhenwei

Hi, @oranagra

I hope I'm not disturbing you... This seems to have been ignored, could you please take a look at this?

pizhenwei avatar Aug 29 '22 08:08 pizhenwei

I'm not familiar with some of these details myself either.. i'll try to grab the attention of someone who does.. but also, i guess that for the case of redis.io docs, it wouldn't be a terrible idea to include these details, even if they're slightly misplaced... maybe it'll help someone, and maybe some future edit will change / improve them...

oranagra avatar Aug 29 '22 09:08 oranagra

@ushachar, this information is available in Red Hat Linux training and docs. I recommend not adding this information to our docs as third-party docs may change.

nermiller avatar Nov 10 '22 19:11 nermiller

Hi, @nermiller @ushachar @itamarhaber

From your suggestions, closing this PR seems right. Thanks for your suggestions!

pizhenwei avatar Nov 11 '22 00:11 pizhenwei