node-redis icon indicating copy to clipboard operation
node-redis copied to clipboard

understand that null responses can be returned for the key/value array

Open sjpotter opened this issue 1 year ago • 2 comments

in #2772 users noted that we are throwing a javascript exception as we are trying to apply .length to a null and hence that fails.

we have 2 options. First, we can just elide these results from the response we give the user, but this wouldn't correspond to the ft.search documentation. Therefore, instead, as redis doesn't return a document, but a null, we should do the same, and return an empty null object for these documents. It's up to the user to handle them

fixes #2772

Description

Describe your pull request here


Checklist

  • [ ] Does npm test pass with this change (including linting)?
  • [ ] Is the new or changed code fully tested?
  • [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

sjpotter avatar Aug 08 '24 07:08 sjpotter

is there any update on this? 👀

CaptainTux avatar Nov 11 '24 00:11 CaptainTux

any update on this?

samyakkkk avatar Apr 28 '25 09:04 samyakkkk

Closing this one as #2772 was fixed in #2988

nkaradzhov avatar Nov 18 '25 08:11 nkaradzhov