jedis icon indicating copy to clipboard operation
jedis copied to clipboard

A demo of redis version tag proposal

Open cjx-zar opened this issue 2 years ago • 3 comments

This is a demo for annotating the compatible Redis version of the test cases in SetCommandsTest. #3471

In RedisType, we can define all compatible Redis versions. Then we use "@EnabledOnRedis" to specify that certain test cases can only be run on their compatible Redis versions.

When testing, we can use "mvn -Dredisversion=redis_xx" to set the version of Redis.

For example, in SetCommandsTest, Redis 6.0 does not support "sintercard", "sinterstore", and "smismember" commands, and we can skip these cases using "mvn -Dredisversion=redis_6".

cjx-zar avatar Jun 20 '23 10:06 cjx-zar

@cjx-zar Thank you for your interest in improving Jedis tests.

It'd take quite some time for me to review. Please keep some patience until someone else reviews or I come back. Thanks again.

sazzad16 avatar Jun 20 '23 14:06 sazzad16

Codecov Report

Patch coverage: 5.03% and project coverage change: -65.44 :warning:

Comparison is base (7331a7b) 71.30% compared to head (e70cfe9) 5.87%.

:exclamation: Current head e70cfe9 differs from pull request most recent head 47c00aa. Consider uploading reports for the commit 47c00aa to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #3473       +/-   ##
============================================
- Coverage     71.30%   5.87%   -65.44%     
+ Complexity     4745     251     -4494     
============================================
  Files           275     277        +2     
  Lines         14740   14841      +101     
  Branches        990    1017       +27     
============================================
- Hits          10511     872     -9639     
- Misses         3800   13903    +10103     
+ Partials        429      66      -363     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Jedis.java 4.71% <0.00%> (-80.61%) :arrow_down:
...va/redis/clients/jedis/JedisShardedPubSubBase.java 0.00% <ø> (-70.91%) :arrow_down:
src/main/java/redis/clients/jedis/Module.java 0.00% <ø> (-33.34%) :arrow_down:
...ava/redis/clients/jedis/MultiNodePipelineBase.java 0.00% <0.00%> (-72.59%) :arrow_down:
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 0.00% <0.00%> (-74.38%) :arrow_down:
...ients/jedis/json/commands/RedisJsonV1Commands.java 0.00% <0.00%> (ø)
...dis/json/commands/RedisJsonV1PipelineCommands.java 0.00% <0.00%> (ø)
...ients/jedis/json/commands/RedisJsonV2Commands.java 0.00% <0.00%> (ø)
...dis/json/commands/RedisJsonV2PipelineCommands.java 0.00% <0.00%> (ø)
...dis/clients/jedis/resps/AccessControlLogEntry.java 0.00% <ø> (-87.10%) :arrow_down:
... and 16 more

... and 222 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jun 28 '23 09:06 codecov-commenter

should jedis compatible with multiple redis versions(5.x,6.x,7.x ) with one version? acturally, i meet some compatible issue whille upgrade redis from 5.x->6.x. add more compile option seems good.

chenshi5012 avatar Aug 15 '23 09:08 chenshi5012