hiredis-py icon indicating copy to clipboard operation
hiredis-py copied to clipboard

Update Python 3.13 compatibility

Open DeD1rk opened this issue 1 year ago • 1 comments

Fixes #186

Updates CI to build cp313 wheels. Adds pypy-3.10 testing as well.

See also https://github.com/redis/hiredis-py/pull/174.

@chayim could you take a look?

DeD1rk avatar Oct 19 '24 08:10 DeD1rk

Update: I now see https://github.com/redis/hiredis-py/pull/198/files, so my comment below doesn't really apply.

As a sidenote, CHANGELOG.md doesn't match the release notes any more. So perhaps it's time to drop it, or update it up to a certain version and indicate that from then on, the github release notes server as changelog. If you agree I'm happy to make those changes of course.

DeD1rk avatar Oct 19 '24 09:10 DeD1rk

@DeD1rk @badboy @pietern @jparise @banker Is there some progress on that issue, as it would be terrific to allow it for Python 3.13. 🙂

junoriosity avatar Nov 02 '24 19:11 junoriosity

I don't maintain this project anymore.

badboy avatar Nov 03 '24 10:11 badboy

I think maintainers moved to valkey or something :grimacing:

Zaczero avatar Nov 04 '24 01:11 Zaczero

@vladvildanov you

chayim avatar Nov 17 '24 19:11 chayim

Thanks @chayim for pinging me!

Guys just tag me on the PR's if you need a review

vladvildanov avatar Nov 18 '24 08:11 vladvildanov

Hey @vladvildanov could you cut a new release for hi-redis so there would be python 3.13 wheels in pypi?

hxyannay avatar Dec 02 '24 08:12 hxyannay

@hxyannay Hey! Planned later this week

vladvildanov avatar Dec 03 '24 08:12 vladvildanov

@hxyannay Already available

vladvildanov avatar Dec 04 '24 11:12 vladvildanov

Hey @vladvildanov I see that you released v3.1.0, but I do not see it under pypi here: https://pypi.org/simple/hiredis/ Also I see that the latest github action run failed on publishing to pypi, so maybe that's the cause.

hxyannay avatar Dec 04 '24 12:12 hxyannay

@hxyannay FIxed

vladvildanov avatar Dec 04 '24 14:12 vladvildanov

Thank you @vladvildanov 🙏

hxyannay avatar Dec 05 '24 09:12 hxyannay