go-redis icon indicating copy to clipboard operation
go-redis copied to clipboard

Published 20 hours ago • verified publisher icon redis

Possible data race

Open vmihailenco opened this issue 4 years ago • 9 comments
trafficstars

Full build log: https://travis-ci.org/github/go-redis/redis/jobs/757558441 . Help is appreciated - so far I was not able to understand what is happening.

For example:

WARNING: DATA RACE
Read at 0x00c000010598 by goroutine 27:
  internal/race.ReadRange()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/internal/race/race.go:45 +0xab
  syscall.Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/syscall/syscall_unix.go:217 +0x8f
  internal/poll.(*FD).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/internal/poll/fd_unix.go:268 +0x1f8
  net.(*netFD).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/net/fd_unix.go:220 +0x65
  net.(*conn).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/net/net.go:196 +0xa0
  net.(*TCPConn).Write()
      <autogenerated>:1 +0x69
  bufio.(*Writer).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/bufio/bufio.go:623 +0x184
  github.com/go-redis/redis/v8/internal/proto.(*Writer).bytes()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:122 +0xf7
  github.com/go-redis/redis/v8/internal/proto.(*Writer).string()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:130 +0xf6e
  github.com/go-redis/redis/v8/internal/proto.(*Writer).WriteArg()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:66 +0xf86
  github.com/go-redis/redis/v8/internal/proto.(*Writer).WriteArgs()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:46 +0xf9
  github.com/go-redis/redis/v8.writeCmd()
      /home/travis/gopath/src/github.com/go-redis/redis/command.go:59 +0x4c
  github.com/go-redis/redis/v8.writeCmds()
      /home/travis/gopath/src/github.com/go-redis/redis/command.go:51 +0x87
  github.com/go-redis/redis/v8.(*baseClient).txPipelineProcessCmds.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:488 +0x77
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithWriter.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/pool/conn.go:92 +0x4c7
  github.com/go-redis/redis/v8/internal.WithSpan()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/util.go:59 +0x286
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithWriter()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/pool/conn.go:83 +0xa8
  github.com/go-redis/redis/v8.(*baseClient).txPipelineProcessCmds()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:487 +0xc1
  github.com/go-redis/redis/v8.(*baseClient).txPipelineProcessCmds-fm()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:484 +0x90
  github.com/go-redis/redis/v8.(*baseClient)._generalProcessPipeline.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:447 +0x8b
  github.com/go-redis/redis/v8.(*baseClient).withConn.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:309 +0x43b
  github.com/go-redis/redis/v8/internal.WithSpan()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/util.go:59 +0x286
  github.com/go-redis/redis/v8.(*baseClient).withConn()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:291 +0x9c
  github.com/go-redis/redis/v8.(*baseClient)._generalProcessPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:445 +0x1f6
  github.com/go-redis/redis/v8.(*baseClient).generalProcessPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:425 +0x8a
  github.com/go-redis/redis/v8.(*baseClient).processTxPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:417 +0xdc
  github.com/go-redis/redis/v8.(*baseClient).processTxPipeline-fm()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:416 +0x7a
  github.com/go-redis/redis/v8.hooks.processPipeline.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:95 +0x92
  github.com/go-redis/redis/v8.hooks.withContext()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:134 +0x438
  github.com/go-redis/redis/v8.hooks.processPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:94 +0x3ad
  github.com/go-redis/redis/v8.hooks.processTxPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:130 +0x43b
  github.com/go-redis/redis/v8.(*Tx).TxPipeline.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/tx.go:143 +0xe9
  github.com/go-redis/redis/v8.(*Pipeline).Exec()
      /home/travis/gopath/src/github.com/go-redis/redis/pipeline.go:115 +0x1ca
  github.com/go-redis/redis/v8.(*Pipeline).Pipelined()
      /home/travis/gopath/src/github.com/go-redis/redis/pipeline.go:122 +0xda
  github.com/go-redis/redis/v8.(*Tx).TxPipelined()
      /home/travis/gopath/src/github.com/go-redis/redis/tx.go:135 +0x7d
  github.com/go-redis/redis/v8_test.glob..func22.6.1()
      /home/travis/gopath/src/github.com/go-redis/redis/ring_test.go:466 +0x87
  github.com/go-redis/redis/v8.(*Client).Watch()
      /home/travis/gopath/src/github.com/go-redis/redis/tx.go:74 +0xfa
  github.com/go-redis/redis/v8.(*Ring).Watch()
      /home/travis/gopath/src/github.com/go-redis/redis/ring.go:722 +0x2c0
  github.com/go-redis/redis/v8_test.glob..func22.6()
      /home/travis/gopath/src/github.com/go-redis/redis/ring_test.go:465 +0x104
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:113 +0xf3
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:64 +0x107
  github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/it_node.go:26 +0x87
  github.com/onsi/ginkgo/internal/spec.(*Spec).runSample()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:215 +0x6e1
  github.com/onsi/ginkgo/internal/spec.(*Spec).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:138 +0x17e
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:200 +0x172
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:170 +0x216
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:66 +0x140
  github.com/onsi/ginkgo/internal/suite.(*Suite).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/suite/suite.go:79 +0x86a
  github.com/onsi/ginkgo.RunSpecsWithCustomReporters()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:229 +0x349
  github.com/onsi/ginkgo.RunSpecs()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:210 +0x24d
  github.com/go-redis/redis/v8_test.TestGinkgoSuite()
      /home/travis/gopath/src/github.com/go-redis/redis/main_test.go:117 +0xf8
  testing.tRunner()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/testing/testing.go:1050 +0x1eb
Previous write at 0x00c000010598 by goroutine 151:
  github.com/go-redis/redis/v8.(*ClusterClient).pubSub.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/cluster.go:1507 +0x119
  github.com/go-redis/redis/v8.(*PubSub).conn()
      /home/travis/gopath/src/github.com/go-redis/redis/pubsub.go:79 +0x1a7
  github.com/go-redis/redis/v8.(*PubSub).reconnect()
      /home/travis/gopath/src/github.com/go-redis/redis/pubsub.go:160 +0x83
  github.com/go-redis/redis/v8.(*PubSub).initPing.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/pubsub.go:503 +0x2e3

Or

WARNING: DATA RACE
Read at 0x00c00003ee18 by goroutine 27:
  internal/race.ReadRange()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/internal/race/race.go:45 +0xab
  syscall.Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/syscall/syscall_unix.go:217 +0x8f
  internal/poll.(*FD).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/internal/poll/fd_unix.go:268 +0x1f8
  net.(*netFD).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/net/fd_unix.go:220 +0x65
  net.(*conn).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/net/net.go:196 +0xa0
  net.(*TCPConn).Write()
      <autogenerated>:1 +0x69
  bufio.(*Writer).Write()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/bufio/bufio.go:623 +0x184
  github.com/go-redis/redis/v8/internal/proto.(*Writer).bytes()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:122 +0xf7
  github.com/go-redis/redis/v8/internal/proto.(*Writer).string()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:130 +0xf6e
  github.com/go-redis/redis/v8/internal/proto.(*Writer).WriteArg()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:66 +0xf86
  github.com/go-redis/redis/v8/internal/proto.(*Writer).WriteArgs()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/proto/writer.go:46 +0xf9
  github.com/go-redis/redis/v8.writeCmd()
      /home/travis/gopath/src/github.com/go-redis/redis/command.go:59 +0x4c
  github.com/go-redis/redis/v8.writeCmds()
      /home/travis/gopath/src/github.com/go-redis/redis/command.go:51 +0x87
  github.com/go-redis/redis/v8.(*baseClient).txPipelineProcessCmds.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:488 +0x77
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithWriter.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/pool/conn.go:92 +0x4c7
  github.com/go-redis/redis/v8/internal.WithSpan()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/util.go:59 +0x286
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithWriter()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/pool/conn.go:83 +0xa8
  github.com/go-redis/redis/v8.(*baseClient).txPipelineProcessCmds()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:487 +0xc1
  github.com/go-redis/redis/v8.(*baseClient).txPipelineProcessCmds-fm()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:484 +0x90
  github.com/go-redis/redis/v8.(*baseClient)._generalProcessPipeline.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:447 +0x8b
  github.com/go-redis/redis/v8.(*baseClient).withConn.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:309 +0x43b
  github.com/go-redis/redis/v8/internal.WithSpan()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/util.go:59 +0x286
  github.com/go-redis/redis/v8.(*baseClient).withConn()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:291 +0x9c
  github.com/go-redis/redis/v8.(*baseClient)._generalProcessPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:445 +0x1f6
  github.com/go-redis/redis/v8.(*baseClient).generalProcessPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:425 +0x8a
  github.com/go-redis/redis/v8.(*baseClient).processTxPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:417 +0xdc
  github.com/go-redis/redis/v8.(*baseClient).processTxPipeline-fm()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:416 +0x7a
  github.com/go-redis/redis/v8.hooks.processPipeline.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:95 +0x92
  github.com/go-redis/redis/v8.hooks.withContext()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:134 +0x438
  github.com/go-redis/redis/v8.hooks.processPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:94 +0x3ad
  github.com/go-redis/redis/v8.hooks.processTxPipeline()
      /home/travis/gopath/src/github.com/go-redis/redis/redis.go:130 +0x43b
  github.com/go-redis/redis/v8.(*Tx).TxPipeline.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/tx.go:143 +0xe9
  github.com/go-redis/redis/v8.(*Pipeline).Exec()
      /home/travis/gopath/src/github.com/go-redis/redis/pipeline.go:115 +0x1ca
  github.com/go-redis/redis/v8.(*Pipeline).Pipelined()
      /home/travis/gopath/src/github.com/go-redis/redis/pipeline.go:122 +0xda
  github.com/go-redis/redis/v8.(*Tx).TxPipelined()
      /home/travis/gopath/src/github.com/go-redis/redis/tx.go:135 +0x7d
  github.com/go-redis/redis/v8_test.glob..func22.6.1()
      /home/travis/gopath/src/github.com/go-redis/redis/ring_test.go:466 +0x87
  github.com/go-redis/redis/v8.(*Client).Watch()
      /home/travis/gopath/src/github.com/go-redis/redis/tx.go:74 +0xfa
  github.com/go-redis/redis/v8.(*Ring).Watch()
      /home/travis/gopath/src/github.com/go-redis/redis/ring.go:722 +0x2c0
  github.com/go-redis/redis/v8_test.glob..func22.6()
      /home/travis/gopath/src/github.com/go-redis/redis/ring_test.go:465 +0x104
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:113 +0xf3
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:64 +0x107
  github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/it_node.go:26 +0x87
  github.com/onsi/ginkgo/internal/spec.(*Spec).runSample()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:215 +0x6e1
  github.com/onsi/ginkgo/internal/spec.(*Spec).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:138 +0x17e
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:200 +0x172
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:170 +0x216
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:66 +0x140
  github.com/onsi/ginkgo/internal/suite.(*Suite).Run()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/internal/suite/suite.go:79 +0x86a
  github.com/onsi/ginkgo.RunSpecsWithCustomReporters()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:229 +0x349
  github.com/onsi/ginkgo.RunSpecs()
      /home/travis/gopath/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:210 +0x24d
  github.com/go-redis/redis/v8_test.TestGinkgoSuite()
      /home/travis/gopath/src/github.com/go-redis/redis/main_test.go:117 +0xf8
  testing.tRunner()
      /home/travis/.gimme/versions/go1.14.14.linux.amd64/src/testing/testing.go:1050 +0x1eb
Previous write at 0x00c00003ee18 by goroutine 208:
  github.com/go-redis/redis/v8.newClusterState()
      /home/travis/gopath/src/github.com/go-redis/redis/cluster.go:478 +0x7da
  github.com/go-redis/redis/v8.(*ClusterClient).loadState()
      /home/travis/gopath/src/github.com/go-redis/redis/cluster.go:998 +0x20f
  github.com/go-redis/redis/v8.(*ClusterClient).loadState-fm()
      /home/travis/gopath/src/github.com/go-redis/redis/cluster.go:992 +0x59
  github.com/go-redis/redis/v8.(*clusterStateHolder).Reload()
      /home/travis/gopath/src/github.com/go-redis/redis/cluster.go:627 +0x5e
  github.com/go-redis/redis/v8.(*clusterStateHolder).LazyReload.func1()
      /home/travis/gopath/src/github.com/go-redis/redis/cluster.go:642 +0xae

vmihailenco avatar Feb 09 '21 14:02 vmihailenco

@monkey92t The same build you've mentioned at https://github.com/golang/go/issues/44672 contains more baffling/unexplained race

Previous write at 0x00c00004c4e8 by goroutine 7:
  time.(*Time).addSec()
      /home/travis/.gimme/versions/go1.15.8.linux.amd64/src/time/time.go:193 +0x84
  time.Time.Add()
      /home/travis/.gimme/versions/go1.15.8.linux.amd64/src/time/time.go:824 +0xa7
  time.Time.Sub()
      /home/travis/.gimme/versions/go1.15.8.linux.amd64/src/time/time.go:857 +0x19b
  github.com/go-redis/redis/v8/internal/pool.(*ConnPool).isStaleConn()
      /home/travis/gopath/src/github.com/go-redis/redis/internal/pool/pool.go:517 +0x224

Where pool.go:517 is atomic.LoadUint64 and accompanying read looks completely unrelated.

I would suspect the memory is corrupted somehow, but I don't see any crashes reported.

Actually the first race in that build does not make much sense too. The read is reported to be in /home/travis/gopath/src/github.com/go-redis/redis/tx_test.go:106 +0x89 and write in /home/travis/gopath/src/github.com/go-redis/redis/ring.go:317 +0x1a6. Those are 2 different tests and different clients that should not share anything.

vmihailenco avatar Mar 16 '21 07:03 vmihailenco

I think it may be that some kind of operation interruption may trigger such a problem (but I am not sure what operation was interrupted)

I often press "control+c" to cancel the execution of the unit in a unit test, and sometimes I can see the data race that I can't understand.

If the execution of the unit test is interrupted due to other errors, will the same effect be achieved?

After I recently fixed some unit test errors that may appear, it is difficult for me to encounter this data race error anymore.

monkey92t avatar Mar 16 '21 07:03 monkey92t

If the execution of the unit test is interrupted due to other errors, will the same effect be achieved?

It definitely should not. But I can't explain what is happening so it may actually be the reason.

I think it is safe to say that these are not real races, but we may have a serious problem that is uncovered by race detector. In such case the code should crash in production which is not happening...

  • either because we have unusual configuration in tests
  • or the problem is only triggered when there are multiple clients

The best thing we can do is

  1. Try to reliably reproduce this locally. By reliably I mean at least one failure in 100 builds (run tests in the loop). Perhaps it makes sense to disable cluster & sentinel tests to make build faster.
  2. Try to get rid of unsafe and see if the problem goes away.
  3. Make some other changes that are likely to make a change :)

vmihailenco avatar Mar 16 '21 08:03 vmihailenco

During the weekend, I have run 3 containers*30 hours of testing continuously. Unfortunately, the data race I was expecting did not appear. I even began to wonder if this error has been accidentally fixed.

I plan to do even crazier testing this week and look forward to it. redis-cluster performance is not stable, I plan to disable it before performing the test.

monkey92t avatar Mar 16 '21 08:03 monkey92t

Wow, that is impressive and should be more than enough judging by the build history. Going to try this locally on Go 1.6.2

#!/bin/bash
for i in {1..100}
do
    echo $i
    GOFLAGS="-count=1" go test ./... -short -race
done

Will report if I get any results...

vmihailenco avatar Mar 16 '21 09:03 vmihailenco

No failures locally after 100 runs.

vmihailenco avatar Mar 16 '21 11:03 vmihailenco

travis-ci seems more likely to appear: https://travis-ci.org/github/go-redis/redis/jobs/763230641

monkey92t avatar Mar 17 '21 08:03 monkey92t

I encountered an unintelligible data race locally, I think it should not appear under any circumstances. This is all the error messages, no more.

code:

//race_amd64.s
//226 // Store
//227 TEXT    sync?~H~Uatomic·StoreInt32(SB), NOSPLIT, $0-0
//228         MOVQ    $__tsan_go_atomic32_store(SB), AX
//229         CALL    racecallatomic<>(SB)
//230         RET

//redis.go
//146 func newBaseClient(opt *Options, connPool pool.Pooler) *baseClient {
//147 	return &baseClient{
//148 		opt:      opt,
//149 		connPool: connPool,
//150 	}
//151 }

WARNING: DATA RACE
Write at 0x00c0006fe198 by goroutine 889:
  sync/atomic.StoreInt32()
      /usr/local/go/src/runtime/race_amd64.s:229 +0xb
  github.com/go-redis/redis/v8.(*clusterStateHolder).LazyReload.func1()
      /redis/cluster.go:647 +0xf6

Previous write at 0x00c0006fe198 by goroutine 566:
  github.com/go-redis/redis/v8.newBaseClient()
      /redis/redis.go:147 +0xba
  github.com/go-redis/redis/v8.NewClient()
      /redis/redis.go:571 +0x70
  github.com/go-redis/redis/v8.newClusterNode()
      /redis/cluster.go:180 +0x70a
  github.com/go-redis/redis/v8.(*clusterNodes).Get()
      /redis/cluster.go:371 +0x1fb
  github.com/go-redis/redis/v8.(*ClusterClient).checkMovedErr()
      /redis/cluster.go:1225 +0xea
  github.com/go-redis/redis/v8.(*ClusterClient).pipelineReadCmds()
      /redis/cluster.go:1201 +0x189
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode.func1.1.2()
      /redis/cluster.go:1180 +0x8e
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithReader.func1()
      /redis/internal/pool/conn.go:73 +0x43e
  github.com/go-redis/redis/v8/internal.WithSpan()
      /redis/internal/util.go:59 +0x296
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithReader()
      /redis/internal/pool/conn.go:69 +0xa8
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode.func1.1()
      /redis/cluster.go:1179 +0x2cd
  github.com/go-redis/redis/v8.(*baseClient).withConn.func1()
      /redis/redis.go:309 +0x459
  github.com/go-redis/redis/v8/internal.WithSpan()
      /redis/internal/util.go:59 +0x296
  github.com/go-redis/redis/v8.(*baseClient).withConn()
      /redis/redis.go:291 +0x9c
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode.func1()
      /redis/cluster.go:1171 +0x1c9
  github.com/go-redis/redis/v8.hooks.processPipeline.func1()
      /redis/redis.go:95 +0x92
  github.com/go-redis/redis/v8.hooks.withContext()
      /redis/redis.go:134 +0x450
  github.com/go-redis/redis/v8.hooks.processPipeline()
      /redis/redis.go:94 +0x3c5
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode()
      /redis/cluster.go:1170 +0x126
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipeline.func1()
      /redis/cluster.go:1104 +0xea

Goroutine 889 (running) created at:
  github.com/go-redis/redis/v8.(*clusterStateHolder).LazyReload()
      /redis/cluster.go:639 +0x7a
  github.com/go-redis/redis/v8.(*ClusterClient).checkMovedErr()
      /redis/cluster.go:1231 +0x38b
  github.com/go-redis/redis/v8.(*ClusterClient).pipelineReadCmds()
      /redis/cluster.go:1201 +0x189
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode.func1.1.2()
      /redis/cluster.go:1180 +0x8e
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithReader.func1()
      /redis/internal/pool/conn.go:73 +0x43e
  github.com/go-redis/redis/v8/internal.WithSpan()
      /redis/internal/util.go:59 +0x296
  github.com/go-redis/redis/v8/internal/pool.(*Conn).WithReader()
      /redis/internal/pool/conn.go:69 +0xa8
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode.func1.1()
      /redis/cluster.go:1179 +0x2cd
  github.com/go-redis/redis/v8.(*baseClient).withConn.func1()
      /redis/redis.go:309 +0x459
  github.com/go-redis/redis/v8/internal.WithSpan()
      /redis/internal/util.go:59 +0x296
  github.com/go-redis/redis/v8.(*baseClient).withConn()
      /redis/redis.go:291 +0x9c
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode.func1()
      /redis/cluster.go:1171 +0x1c9
  github.com/go-redis/redis/v8.hooks.processPipeline.func1()
      /redis/redis.go:95 +0x92
  github.com/go-redis/redis/v8.hooks.withContext()
      /redis/redis.go:134 +0x450
  github.com/go-redis/redis/v8.hooks.processPipeline()
      /redis/redis.go:94 +0x3c5
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipelineNode()
      /redis/cluster.go:1170 +0x126
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipeline.func1()
      /redis/cluster.go:1104 +0xea

Goroutine 566 (finished) created at:
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipeline()
      /redis/cluster.go:1101 +0x2a7
  github.com/go-redis/redis/v8.(*ClusterClient)._processPipeline-fm()
      /redis/cluster.go:1080 +0x7a
  github.com/go-redis/redis/v8.hooks.processPipeline.func1()
      /redis/redis.go:95 +0x92
  github.com/go-redis/redis/v8.hooks.withContext()
      /redis/redis.go:134 +0x450
  github.com/go-redis/redis/v8.hooks.processPipeline()
      /redis/redis.go:94 +0x3c5
  github.com/go-redis/redis/v8.(*ClusterClient).processPipeline()
      /redis/cluster.go:1077 +0xd6
  github.com/go-redis/redis/v8.(*ClusterClient).processPipeline-fm()
      /redis/cluster.go:1076 +0x7a
  github.com/go-redis/redis/v8.(*Pipeline).Exec()
      /redis/pipeline.go:115 +0x1d1
  github.com/go-redis/redis/v8_test.glob..func1.1.8.1.2()
      /redis/cluster_test.go:454 +0x5c4
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:113 +0xfc
  github.com/onsi/ginkgo/internal/leafnodes.(*runner).run()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/runner.go:64 +0x184
  github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/leafnodes/it_node.go:26 +0xb9
  github.com/onsi/ginkgo/internal/spec.(*Spec).runSample()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:215 +0x7fd
  github.com/onsi/ginkgo/internal/spec.(*Spec).Run()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/spec/spec.go:138 +0x187
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:200 +0x17b
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:170 +0x22a
  github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/specrunner/spec_runner.go:66 +0x145
  github.com/onsi/ginkgo/internal/suite.(*Suite).Run()
      /gopath/pkg/mod/github.com/onsi/[email protected]/internal/suite/suite.go:79 +0x899
  github.com/onsi/ginkgo.RunSpecsWithCustomReporters()
      /gopath/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:229 +0x35c
  github.com/onsi/ginkgo.RunSpecs()
      /gopath/pkg/mod/github.com/onsi/[email protected]/ginkgo_dsl.go:210 +0x258
  github.com/go-redis/redis/v8_test.TestGinkgoSuite()
      /redis/main_test.go:122 +0x108
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1123 +0x202
==================

monkey92t avatar Mar 18 '21 09:03 monkey92t

Edit: In my case the error was between the chair and the keyboard. My issue is solved and not caused by a data race but by a stackoverflow caused by stupidity.

jtorvald avatar Mar 23 '21 11:03 jtorvald

This issue is marked stale. It will be closed in 30 days if it is not updated.

github-actions[bot] avatar Sep 22 '23 00:09 github-actions[bot]