tuned icon indicating copy to clipboard operation
tuned copied to clipboard

tests/beakerlib/Tuned-takes-too-long-to-reload-start-when-ulimit/runtest.sh should be more clear

Open RHEmployee opened this issue 2 years ago • 3 comments

Test checks if there is delay after tuned start.

It exploits small time window among beakerlib commands which is not clear at first look.

Maybe just add sleep .5 and more comments will help. Or maybe use timeout command in combination with exploit of "race condition".

RHEmployee avatar Aug 03 '23 14:08 RHEmployee

Yep, I think you should use the timeout command or similar mechanism. Now you are only checking that the 'sysctl' log message was removed, which IMHO was.

yarda avatar Aug 03 '23 14:08 yarda

Bug has been revealed in test here: https://github.com/redhat-performance/tuned/pull/421#discussion_r1283258773

RHEmployee avatar Aug 03 '23 14:08 RHEmployee

Proposed fix: https://github.com/redhat-performance/tuned/pull/545

RHEmployee avatar Aug 04 '23 07:08 RHEmployee