tuned icon indicating copy to clipboard operation
tuned copied to clipboard

Updating docstring for the audio plugin

Open courtneypacheco opened this issue 4 years ago • 4 comments

Updating the docstring for the audio plugin to include more info and sample usage

courtneypacheco avatar Dec 30 '20 15:12 courtneypacheco

Thank you for the PR. Why is this PR exactly the same as https://github.com/redhat-performance/tuned/pull/315 ? I.e., both include docstrings for sysctl and audio plugins. Also, I'd suggest squashing the commits to a bare minimum prior to merge. Finally, I remember having been asked to --signoff by tuned mainainers in the past (see the git log).

jmencak avatar Jan 04 '21 11:01 jmencak

Thank you for the PR. Why is this PR exactly the same as #315 ? I.e., both include docstrings for sysctl and audio plugins. Also, I'd suggest squashing the commits to a bare minimum prior to merge. Finally, I remember having been asked to --signoff by tuned mainainers in the past (see the git log).

Yeah, I made a mistake when pushing the commit. I'll squash the commits next time and check to see why I have the sysctl and audio plugins in the same commit. I apologize for that. Not sure why I'm getting both plugin docstrings in this PR.

courtneypacheco avatar Jan 04 '21 14:01 courtneypacheco

@courtneypacheco please squash the commits to one. Use e.g. git rebase -i for it, then force push from the branch git push -f.

yarda avatar Jan 21 '21 11:01 yarda

Obsoleted by: https://github.com/redhat-performance/tuned/pull/337

jmencak avatar Apr 08 '21 09:04 jmencak