Make exec package agnostic of platform

[feloy]

What type of PR is this:

/kind code-refactoring

What does this PR do / why we need it:

This package makes the exec package, and thus the sync package using it, agnostic of the platform. The platform is injected by the dependency injection system, depending on the --run-on flag.

Which issue(s) this PR fixes:

Fixes #6160

PR acceptance criteria:

• [ ] Unit test

• [ ] Integration test

• [ ] Documentation

How to test changes / Special notes to the reviewer:

[openshift-ci[bot]]

@feloy: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:

/kind cleanup

What does this PR do / why we need it:

This package makes the exec package, and thus the sync package using it, agnostic of the platform. The platform is injected by the dependency injection system, depending on the --run-on flag.

Which issue(s) this PR fixes:

Fixes #6160

PR acceptance criteria:

• [ ] Unit test

• [ ] Integration test

• [ ] Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify[bot]]

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	c341db36a580fdc5578261b0ad95bd8bf159cc34
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63517594f8502a0008558acd

[odo-robot[bot]]

Unit Tests on commit 58e4601742f92730483e66d0161c11df0ceff628 finished successfully. View logs: TXT HTML

[odo-robot[bot]]

Validate Tests on commit 58e4601742f92730483e66d0161c11df0ceff628 finished successfully. View logs: TXT HTML

[odo-robot[bot]]

Windows Tests (OCP) on commit 58e4601742f92730483e66d0161c11df0ceff628 finished successfully. View logs: TXT HTML

[odo-robot[bot]]

Kubernetes Tests on commit 58e4601742f92730483e66d0161c11df0ceff628 finished with errors. View logs: TXT HTML

[odo-robot[bot]]

OpenShift Tests on commit 58e4601742f92730483e66d0161c11df0ceff628 finished with errors. View logs: TXT HTML

[valaparthvi]

/retest

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [rm3l]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[valaparthvi]

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests /override OpenShift-Integration-tests/OpenShift-Integration-tests /override ci/prow/v4.11-integration-e2e Overriding the tests. All point to the same failures.

Summarizing 2 Failures:
  [FAIL] E2E Test starting with non-empty Directory [It] should verify developer workflow from non-empty Directory
  /go/src/github.com/redhat-developer/odo/tests/helper/helper_interactive.go:111
  [FAIL] E2E Test starting with empty Directory [It] should verify developer workflow from empty Directory
  /go/src/github.com/redhat-developer/odo/tests/helper/helper_generic.go:76

Ran 6 of 6 Specs in 162.545 seconds
FAIL! -- 4 Passed | 2 Failed | 0 Pending | 0 Skipped

@feloy I think it's alright to merge this PR given the errors. But I am going to put this on hold, in case you'd like to wait until #6243 goes in. Feel free to remove the hold if you want it to go in right away.

/hold

[openshift-ci[bot]]

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests, ci/prow/v4.11-integration-e2e

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests /override OpenShift-Integration-tests/OpenShift-Integration-tests /override ci/prow/v4.11-integration-e2e Overriding the tests. All point to the same failure.

Summarizing 2 Failures:
 [FAIL] E2E Test starting with non-empty Directory [It] should verify developer workflow from non-empty Directory
 /go/src/github.com/redhat-developer/odo/tests/helper/helper_interactive.go:111
 [FAIL] E2E Test starting with empty Directory [It] should verify developer workflow from empty Directory
 /go/src/github.com/redhat-developer/odo/tests/helper/helper_generic.go:76

Ran 6 of 6 Specs in 162.545 seconds
FAIL! -- 4 Passed | 2 Failed | 0 Pending | 0 Skipped

@feloy I think it's alright to merge this PR given the errors. But I am going to put this on hold, in case you'd like to wait until #6243 goes in. Feel free to remove the hold if you want it to go in right away.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[feloy]

/override NoCluster-Integration-tests/NoCluster-Integration-tests Not applicable

[openshift-ci[bot]]

@feloy: Overrode contexts on behalf of feloy: NoCluster-Integration-tests/NoCluster-Integration-tests

In response to this:

/override NoCluster-Integration-tests/NoCluster-Integration-tests Not applicable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.