Update odo to use go 1.18

[dharmit]

Signed-off-by: Dharmit Shah [email protected]

What type of PR is this: /kind feature

What does this PR do / why we need it: $subject

Which issue(s) this PR fixes:

Fixes #6090

PR acceptance criteria:

• [ ] Unit test

• [ ] Integration test

• [ ] Documentation

How to test changes / Special notes to the reviewer:

• I tested make validate and make test locally before opening the PR. Not sure if there was any other Makefile target that I should have tested locally.
• For a list of steps I followed, PTAL https://github.com/redhat-developer/odo/issues/6090#issuecomment-1255199161.

[netlify[bot]]

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	50bdddc9e58807ce72c6a6d953f505e521369299
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/636b5d0f27fd700008a2f25c
😎 Deploy Preview	https://deploy-preview-6166--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[odo-robot[bot]]

Unit Tests on commit d3d598675d8e085d4f7c9a4dc392af76b31fca16 finished successfully. View logs: TXT HTML

[odo-robot[bot]]

Validate Tests on commit d3d598675d8e085d4f7c9a4dc392af76b31fca16 finished successfully. View logs: TXT HTML

[odo-robot[bot]]

Kubernetes Tests on commit d3d598675d8e085d4f7c9a4dc392af76b31fca16 finished successfully. View logs: TXT HTML

[odo-robot[bot]]

OpenShift Tests on commit d3d598675d8e085d4f7c9a4dc392af76b31fca16 finished successfully. View logs: TXT HTML

[odo-robot[bot]]

Windows Tests (OCP) on commit d3d598675d8e085d4f7c9a4dc392af76b31fca16 finished successfully. View logs: TXT HTML

[anandrkskd]

@dharmit, just wanted to know if we have checked with EXD team if they have go 1.18 on rhel8, I remember we have go1.18 available for rhel7.

[dharmit]

@dharmit, just wanted to know if we have checked with EXD team if they have go 1.18 on rhel8, I remember we have go1.18 available for rhel7.

I have pinged Matej for this. I checked using the brew cli, but couldn't get the answer myself.

[anandrkskd]

I have pinged Matej for this. I checked using the brew cli, but couldn't get the answer myself.

I checked for 1.18 on rhel8 but was not able to find it. for rhel 7 its available AFAIR

[dharmit]

I have pinged Matej for this. I checked using the brew cli, but couldn't get the answer myself.

I checked for 1.18 on rhel8 but was not able to find it. for rhel 7 its available AFAIR

Indeed. That's exactly what I found. But I saw the list had only up to go 1.10, which seems weird to me because it's too old. That's why I have pinged Matej about it since he would know the best. :)

[feloy]

@dharmit All tests fail, did you rebase after this PR? https://github.com/redhat-developer/odo/pull/6164

[dharmit]

@dharmit All tests fail, did you rebase after this PR? #6164

I don't remember if I did or didn't. Anyway, rebased now.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dharmit]

/hold

Putting this on hold to prevent accidental merge till Red Hat Release Engg team says OK to update to 1.18. In the meantime, I'll try to address CI issues and the folks can review/approve it so that it can be merged once we have a go ahead.

[odo-robot[bot]]

NoCluster Tests on commit d3d598675d8e085d4f7c9a4dc392af76b31fca16 finished successfully. View logs: TXT HTML

[dharmit]

/hold

Putting this on hold to prevent accidental merge till Red Hat Release Engg team says OK to update to 1.18. In the meantime, I'll try to address CI issues and the folks can review/approve it so that it can be merged once we have a go ahead.

/hold cancel

Internal systems at RH have been updated to use go 1.18.

[feloy]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[dharmit]

Both failures, NoCluster & OCP prow tests, are attributed to the problem mentioned in #6291 and fixed by #6292.

[sonarqubecloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[dharmit]

<< End Captured GinkgoWriter Output
  Unexpected error:
      <*url.Error | 0xc000170120>: {
          Op: "Get",
          URL: "http://127.0.0.1:45923/",
          Err: <*errors.errorString | 0xc0000b0100>{s: "EOF"},
      }
      Get "http://127.0.0.1:45923/": EOF
  occurred
  In [It] at: /go/src/github.com/redhat-developer/odo/tests/e2escenarios/e2e_test.go:32
------------------------------

overriding since tests are passing on IBM Cloud

/override ci/prow/v4.11-integration-e2e

[openshift-ci[bot]]

@dharmit: Overrode contexts on behalf of dharmit: ci/prow/v4.11-integration-e2e

In response to this:

<< End Captured GinkgoWriter Output
 Unexpected error:
     <*url.Error | 0xc000170120>: {
         Op: "Get",
         URL: "http://127.0.0.1:45923/",
         Err: <*errors.errorString | 0xc0000b0100>{s: "EOF"},
     }
     Get "http://127.0.0.1:45923/": EOF
 occurred
 In [It] at: /go/src/github.com/redhat-developer/odo/tests/e2escenarios/e2e_test.go:32
------------------------------

overriding since tests are passing on IBM Cloud

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.