odo icon indicating copy to clipboard operation
odo copied to clipboard

E2e scenario 3

Open anandrkskd opened this issue 3 years ago • 12 comments

What type of PR is this:

/kind tests

What does this PR do / why we need it:

This PR adds e2e tests for inner-loop, working with bindings both binding as env and binding as file

Which issue(s) this PR fixes:

Fixes #5792

PR acceptance criteria:

  • [ ] Unit test

  • [ ] Integration test

  • [ ] Documentation

How to test changes / Special notes to the reviewer:

anandrkskd avatar Sep 01 '22 10:09 anandrkskd

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
Latest commit 0408a1f83a662f912a96931e99e2c7178a288291
Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6380e4b56d2b77000905adae

netlify[bot] avatar Sep 01 '22 10:09 netlify[bot]

Unit Tests on commit cf03afaf61884ce6ed832bb8f1870aa4dcc56fa8 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Sep 01 '22 10:09 odo-robot[bot]

Validate Tests on commit cf03afaf61884ce6ed832bb8f1870aa4dcc56fa8 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Sep 01 '22 11:09 odo-robot[bot]

Kubernetes Tests on commit cf03afaf61884ce6ed832bb8f1870aa4dcc56fa8 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Sep 01 '22 11:09 odo-robot[bot]

OpenShift Tests on commit cf03afaf61884ce6ed832bb8f1870aa4dcc56fa8 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Sep 01 '22 11:09 odo-robot[bot]

Windows Tests (OCP) on commit cf03afaf61884ce6ed832bb8f1870aa4dcc56fa8 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Sep 21 '22 08:09 odo-robot[bot]

/retest

anandrkskd avatar Sep 21 '22 11:09 anandrkskd

/retest

anandrkskd avatar Sep 22 '22 04:09 anandrkskd

/retest

anandrkskd avatar Sep 22 '22 05:09 anandrkskd

/retest

anandrkskd avatar Oct 20 '22 04:10 anandrkskd

@anandrkskd Can you rebase your branch onto main when you get a chance?

rm3l avatar Oct 23 '22 21:10 rm3l

@anandrkskd Can you rebase again? I did not see #6260 in your branch, and it fixed some of the tests that are failing here.

rm3l avatar Nov 02 '22 13:11 rm3l

/approve

rm3l avatar Nov 02 '22 15:11 rm3l

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Nov 02 '22 15:11 openshift-ci[bot]

NoCluster Tests on commit cf03afaf61884ce6ed832bb8f1870aa4dcc56fa8 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Nov 03 '22 10:11 odo-robot[bot]

Can you rebase (again) this one as well? Test failures should be fixed by https://github.com/redhat-developer/odo/pull/6292. Thanks.

rm3l avatar Nov 09 '22 09:11 rm3l

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Nov 09 '22 09:11 openshift-ci[bot]

Tests passing on Prow, but not on IBM Cloud, with similar errors (net/http: TLS handshake timeout):

[odo]  •  Downloading starter project "nodejs-starter"  ...
    [odo]  ✗  Downloading starter project "nodejs-starter" [10s]
    [odo]  ✗  unable to download starter project "nodejs-starter": Get "[https://github.com/odo-devfiles/nodejs-ex.git/info/refs?service=git-upload-pack":](https://github.com/odo-devfiles/nodejs-ex.git/info/refs?service=git-upload-pack%22:) net/http: TLS handshake timeout
    [odo] the command failed, the devfile has been removed from current directory
    Deleting project: cmd-add-binding-test253onx
    Running kubectl with args [kubectl delete namespaces cmd-add-binding-test253onx --wait=false] and odo env: []
    [kubectl] namespace "cmd-add-binding-test253onx" deleted
    Setting current dir to: /go/odo_1/tests/integration
    Deleting dir: /tmp/1748382796
    Deleting dir: /tmp/2598565857
  << End Captured GinkgoWriter Output

  No future change is possible.  Bailing out early - after 14.022s.
  Running odo with args [odo init --name mynode --devfile-path /go/odo_1/tests/examples/source/devfiles/nodejs/devfile.yaml --starter nodejs-starter] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_cmd_wrapper.go:101

Let's try again..

rm3l avatar Nov 09 '22 12:11 rm3l

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 09 '22 17:11 sonarqubecloud[bot]

@anandrkskd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.10-integration-e2e 527f54cae30e27596e047cff89565415578ac69a link true /test v4.10-integration-e2e
ci/prow/v4.11-integration-e2e 6d0c60390a3b1fd786409e9bfc8fed3a599511c7 link true /test v4.11-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 09 '22 19:11 openshift-ci[bot]

/retest

anandrkskd avatar Nov 16 '22 11:11 anandrkskd

  Interactive mode enabled, please answer the following questions:
   ⚠  Registry DefaultDevfileRegistry is not set up properly with error: invalid character '<' looking for beginning of value, please check the registry URL, and credential and remove add the registry again (refer to `odo preference add registry --help`)

rm3l avatar Nov 22 '22 14:11 rm3l

/retest

anandrkskd avatar Nov 23 '22 12:11 anandrkskd

/test v4.10-integration-e2e

/test v4.10-integration-e2e

rm3l avatar Nov 23 '22 14:11 rm3l

@rm3l: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

  • /test unit-and-validate-test
  • /test v4.10-images
  • /test v4.11-images
  • /test v4.11-integration-e2e
  • /test v4.12-images
  • /test v4.9-images

Use /test all to run all jobs.

In response to this:

/test v4.10-integration-e2e

/test v4.10-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Nov 23 '22 14:11 openshift-ci[bot]

/test v4.11-integration-e2e

rm3l avatar Nov 23 '22 14:11 rm3l

@valaparthvi Based on your last comment, can you take another look at this PR and LGTM it if it's okay for you? Thanks.

rm3l avatar Nov 25 '22 08:11 rm3l

/lgtm

valaparthvi avatar Nov 25 '22 09:11 valaparthvi

The unit-and-validate-test Prow job is reporting the following error:

tests/e2escenarios/e2e_test.go:391:51: cannot use nil as helper.DevSessionOpts value in argument to helper.StartDevMode (typecheck)
			devSession, _, _, _, err = helper.StartDevMode(nil)

@anandrkskd Can you rebase your branch onto main and fix this error? The signature of helper.StartDevMode has changed since #6332.

rm3l avatar Nov 25 '22 09:11 rm3l

New changes are detected. LGTM label has been removed.

openshift-ci[bot] avatar Nov 25 '22 12:11 openshift-ci[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 25 '22 15:11 sonarqubecloud[bot]

@anandrkskd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.10-integration-e2e 527f54cae30e27596e047cff89565415578ac69a link true /test v4.10-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Nov 25 '22 15:11 openshift-ci[bot]

/test v4.11-integration-e2e

rm3l avatar Nov 25 '22 15:11 rm3l