odo icon indicating copy to clipboard operation
odo copied to clipboard

[WIP] Make odo work if optional `metadata.name` field is missing in Devfile

Open rm3l opened this issue 3 years ago • 10 comments

What type of PR is this: /kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes: Fixes #5821

PR acceptance criteria:

  • [x] Unit test

  • [x] Integration test

  • [ ] Documentation

How to test changes / Special notes to the reviewer:

rm3l avatar Aug 09 '22 08:08 rm3l

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Aug 09 '22 08:08 openshift-ci[bot]

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
Latest commit 3aa7bc0f17fbb912c033c9706165cf968ae5058d
Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/630d217cf8f7260008a163db

netlify[bot] avatar Aug 09 '22 08:08 netlify[bot]

/hold

Builds upon #5989 (first commit), so waiting for it to be merged in first. Note: remove the first commit from this branch after #5989 is merged (and upon rebasing onto main)

rm3l avatar Aug 09 '22 08:08 rm3l

Unit Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 09 '22 08:08 odo-robot[bot]

Windows Tests (OCP) on commit 3d0d8837124ad92781455d7eed69aa1224b90127 finished with errors. View logs: TXT HTML

odo-robot[bot] avatar Aug 09 '22 08:08 odo-robot[bot]

Validate Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 09 '22 08:08 odo-robot[bot]

Kubernetes Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 09 '22 08:08 odo-robot[bot]

OpenShift Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML

odo-robot[bot] avatar Aug 09 '22 08:08 odo-robot[bot]

/hold cancel

rm3l avatar Aug 26 '22 15:08 rm3l

/test unit-and-validate-test /test v4.10-integration-e2e

rm3l avatar Aug 26 '22 19:08 rm3l

The devfile "a-devfile-name" from the registry "a-registry" will be downloaded.
Based on the files in the current directory odo detected
Language: 
Project type: 
The devfile "" from the registry "" will be downloaded.
--- FAIL: TestInteractiveBackend_PersonalizeName (0.22s)
    --- FAIL: TestInteractiveBackend_PersonalizeName/no_flag (0.22s)
        controller.go:137: missing call(s) to *asker.MockAsker.AskName(is anything) /go/src/github.com/redhat-developer/odo/pkg/init/backend/interactive_test.go:223
        controller.go:137: aborting test due to missing call(s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x258d712]

/test unit-and-validate-test

rm3l avatar Aug 28 '22 19:08 rm3l

/approve

feloy avatar Aug 29 '22 16:08 feloy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 29 '22 16:08 openshift-ci[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

sonarqubecloud[bot] avatar Aug 29 '22 20:08 sonarqubecloud[bot]

/override ci/prow/unit-and-validate-test /override ci/prow/v4.10-integration-e2e Tests pass on IBM Cloud

feloy avatar Aug 30 '22 06:08 feloy

@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test, ci/prow/v4.10-integration-e2e

In response to this:

/override ci/prow/unit-and-validate-test /override ci/prow/v4.10-integration-e2e Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 30 '22 06:08 openshift-ci[bot]