[WIP] Make odo work if optional `metadata.name` field is missing in Devfile
What type of PR is this: /kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes: Fixes #5821
PR acceptance criteria:
-
[x] Unit test
-
[x] Integration test
-
[ ] Documentation
How to test changes / Special notes to the reviewer:
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Deploy Preview for odo-docusaurus-preview canceled.
| Name | Link |
|---|---|
| Latest commit | 3aa7bc0f17fbb912c033c9706165cf968ae5058d |
| Latest deploy log | https://app.netlify.com/sites/odo-docusaurus-preview/deploys/630d217cf8f7260008a163db |
/hold
Builds upon #5989 (first commit), so waiting for it to be merged in first.
Note: remove the first commit from this branch after #5989 is merged (and upon rebasing onto main)
Unit Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML
Windows Tests (OCP) on commit 3d0d8837124ad92781455d7eed69aa1224b90127 finished with errors. View logs: TXT HTML
Validate Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML
Kubernetes Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML
OpenShift Tests on commit fcac29b036ce0f84c2c43704ce4c12d449625897 finished successfully. View logs: TXT HTML
/hold cancel
/test unit-and-validate-test /test v4.10-integration-e2e
The devfile "a-devfile-name" from the registry "a-registry" will be downloaded.
Based on the files in the current directory odo detected
Language:
Project type:
The devfile "" from the registry "" will be downloaded.
--- FAIL: TestInteractiveBackend_PersonalizeName (0.22s)
--- FAIL: TestInteractiveBackend_PersonalizeName/no_flag (0.22s)
controller.go:137: missing call(s) to *asker.MockAsker.AskName(is anything) /go/src/github.com/redhat-developer/odo/pkg/init/backend/interactive_test.go:223
controller.go:137: aborting test due to missing call(s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x258d712]
/test unit-and-validate-test
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: feloy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [feloy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells
No Coverage information
1.5% Duplication
/override ci/prow/unit-and-validate-test /override ci/prow/v4.10-integration-e2e Tests pass on IBM Cloud
@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test, ci/prow/v4.10-integration-e2e
In response to this:
/override ci/prow/unit-and-validate-test /override ci/prow/v4.10-integration-e2e Tests pass on IBM Cloud
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.