chore: support IJ 2024.2

[sbouchet]

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #889 #823

How to test changes?

[openshift-ci[bot]]

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

[sbouchet]

@martinszuc : is there a way to try out my changes for the integration tests tasks ?
currently it uses the old build.gradle on main and not the one i modified in this PR

[martinszuc]

@martinszuc : is there a way to try out my changes for the integration tests tasks ?
currently it uses the old build.gradle on main and not the one i modified in this PR

@sbouchet The way to do it is create and merge PR on your own fork. After the merge to main the tests are triggered automatically after the Java Ci with Grade run ends (which you can cancel). So you would check the Actions tab on your fork. After that I reset the main branch and repeat.

Not ideal but the reason is limitations because of idea licence.

[sbouchet]

@martinszuc : is there a way to try out my changes for the integration tests tasks ? currently it uses the old build.gradle on main and not the one i modified in this PR

@sbouchet The way to do it is create and merge PR on your own fork. After the merge to main the tests are triggered automatically after the Java Ci with Grade run ends (which you can cancel). So you would check the Actions tab on your fork. After that I reset the main branch and repeat.

Not ideal but the reason is limitations because of idea licence.

ok, i tried it out anfd i can now have a working UI test, but with tests failures. you can check the result here : https://github.com/sbouchet/intellij-openshift-connector/actions/runs/10389016704/job/28766038969 however, locally i can't debug because it deletes my IdeaProject Folder where i store my work ( and source code ). what is your setup ?

[martinszuc]

@sbouchet ok, i tried it out anfd i can now have a working UI test, but with tests failures. you can check the result here : https://github.com/sbouchet/intellij-openshift-connector/actions/runs/10389016704/job/28766038969

I believe this could be idea licence not being present. Have you added the decrypt password to your forks secrets?

however, locally i can't debug because it deletes my IdeaProject Folder where i store my work ( and source code ). what is your setup ?

I dont use IdeaProjects, I have a separate folder for projects. Which is also why I didnt notice this. I will take a look if it needs to be that way. If not, its my oversight from commit and ill try to fix

[sbouchet]

@sbouchet ok, i tried it out anfd i can now have a working UI test, but with tests failures. you can check the result here : https://github.com/sbouchet/intellij-openshift-connector/actions/runs/10389016704/job/28766038969

I believe this could be idea licence not being present. Have you added the decrypt password to your forks secrets?

however, locally i can't debug because it deletes my IdeaProject Folder where i store my work ( and source code ). what is your setup ?

I dont use IdeaProjects, I have a separate folder for projects. Which is also why I didnt notice this. I will take a look if it needs to be that way. If not, its my oversight from commit and ill try to fix

it seems i need 0.4.2-snapshot, with this fix https://github.com/redhat-developer/intellij-common-ui-test-library/commit/7336474ed5f2f006f2dbc3e29d2445a03b5d183b

[sbouchet]

@martinszuc : tests fails with

Initialize IdeaRunner and start IDE
      Starting IDE, setting ideaIsStarted to true
      [ 137852]   WARN - logger -         Failed on step: Search many 'JTreeFixture's by '//div[@class='JBViewport']/*' (StepWorker.kt_step)
      [ 137852]   WARN - logger -     Failed on step: Start IntelliJ Idea ('IU-2024.1') listening on port 8580 (StepWorker.kt_step)

does it means the ide is correctly started but it does not find the correct UI element ? the stacks is

java.lang.reflect.InvocationTargetException
          at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
          at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
          at com.intellij.remoterobot.SearchContext$findAll$1.invoke(SearchContext.kt:78)
          at com.intellij.remoterobot.SearchContext$findAll$1.invoke(SearchContext.kt:76)
          at com.intellij.remoterobot.stepsProcessing.StepWorkerKt.step(StepWorker.kt:23)
          at com.intellij.remoterobot.SearchContext$DefaultImpls.findAll(SearchContext.kt:76)
          at com.intellij.remoterobot.RemoteRobot.findAll(RemoteRobot.kt:32)
          at com.redhat.devtools.intellij.commonuitest.fixtures.dialogs.FlatWelcomeFrame.projectsCount(FlatWelcomeFrame.java:224)
          at com.redhat.devtools.intellij.commonuitest.fixtures.dialogs.FlatWelcomeFrame.clearWorkspace(FlatWelcomeFrame.java:115)
          at com.redhat.devtools.intellij.commonuitest.UITestRunner.lambda$runIde$0(UITestRunner.java:97)
          at com.intellij.remoterobot.stepsProcessing.StepWorkerKt.step(StepWorker.kt:23)
          at com.redhat.devtools.intellij.commonuitest.UITestRunner.runIde(UITestRunner.java:70)
          at org.jboss.tools.intellij.openshift.test.ui.runner.IdeaRunner.startIDE(IdeaRunner.java:42)
          at org.jboss.tools.intellij.openshift.test.ui.junit.TestRunnerExtension.beforeAll(TestRunnerExtension.java:33)
          at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
      Caused by: com.intellij.remoterobot.client.IdeaSideException: Wrapped org.assertj.swing.exception.ComponentLookupException: Unable to find component using matcher org.assertj.swing.core.NameMatcher[name='com.intellij.ui.components.JBList[,0,0,250x456,alignmentX=0.0,alignmentY=0.0,border=ViewBorder{myInsets=com.intellij.util.ui.JBInsets[top=0,left=0,bottom=0,right=0], myBorder=null},flags=33554728,maximumSize=java.awt.Dimension[width=250,height=161],minimumSize=,preferredSize=java.awt.Dimension[width=250,height=161],fixedCellHeight=-1,fixedCellWidth=-1,horizontalScrollIncrement=-1,selectionBackground=IJColorUIResource(color=java.awt.Color[r=47,g=101,b=202], name=List.selectionBackground),selectionForeground=IJColorUIResource(color=java.awt.Color[r=1[87](https://github.com/sbouchet/intellij-openshift-connector/actions/runs/10922868695/job/30318144882#step:6:88),g=187,b=187], name=List.selectionForeground),visibleRowCount=8,layoutOrientation=0]', type=javax.swing.JTree, requireShowing=true].

[sbouchet]

@martinszuc : tests fails with

Initialize IdeaRunner and start IDE
      Starting IDE, setting ideaIsStarted to true
      [ 137852]   WARN - logger -         Failed on step: Search many 'JTreeFixture's by '//div[@class='JBViewport']/*' (StepWorker.kt_step)
      [ 137852]   WARN - logger -     Failed on step: Start IntelliJ Idea ('IU-2024.1') listening on port 8580 (StepWorker.kt_step)

oh my ... just saw that i'm trying to run IU-2024.1 where my actual PR is to support 2024.2 maybe that's why there is some errors !

[adietish]

@sbouchet do we know why the ITs still fail?

[sbouchet]

@sbouchet do we know why the ITs still fail?

yes, because the ITs are using main workflow, not the modified on this PR

[adietish]

/override "Cluster Integration UI Tests Report" "Public Integration UI Tests Report" "ci/prow/e2e-openshift"

[openshift-ci[bot]]

@adietish: Overrode contexts on behalf of adietish: Cluster Integration UI Tests Report, Public Integration UI Tests Report, ci/prow/e2e-openshift

In response to this:

/override "Cluster Integration UI Tests Report" "Public Integration UI Tests Report" "ci/prow/e2e-openshift"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sonarqubecloud[bot]]

Quality Gate failed

Failed conditions
18.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

[sbouchet]

/override ci/prow/e2e-openshift

[openshift-ci[bot]]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [adietish]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[sbouchet]

/override ci/prow/e2e-openshift

[openshift-ci[bot]]

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to this:

/override ci/prow/e2e-openshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.