feat(tests): Add tests for gitops-must-gather

[olivergondza]

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind bug /kind cleanup /kind failing-test

/kind enhancement

/kind documentation /kind code-refactoring

What does this PR do / why we need it:

Automate correctness and compatibility of the https://github.com/redhat-developer/gitops-must-gather/

Have you updated the necessary documentation?

• [no] Documentation update is required by this PR.
• [no] Documentation has been updated.

Which issue(s) this PR fixes:

None

Test acceptance criteria:

• [no] Unit Test
• [YES] E2E Test

How to test changes / Special notes to the reviewer:

To be tested as (local running operator): env LOCAL_RUN=true ./bin/ginkgo -v -focus "validate_running_must_gather" -r ./test/openshift/e2e/ginkgo/parallel/.

[openshift-ci[bot]]

Hi @olivergondza. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jgwest]

/ok-to-test

[olivergondza]

Any idea why this pattern is failing only in this newely added test?

Error: test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go:31:2: ST1001: should not use dot imports (staticcheck)
215
	. "github.com/onsi/ginkgo/v2"
216
	^
217
Error: test/openshift/e2e/ginkgo/parallel/1-120_validate_running_must_gather.go:32:2: ST1001: should not use dot imports (staticcheck)
218
	. "github.com/onsi/gomega"
219
	^
220
2 issues:
221
* staticcheck: 2
222
make: *** [Makefile:364: lint] Error 1

https://github.com/redhat-developer/gitops-operator/actions/runs/17559040088/job/49870492021?pr=958

[olivergondza]

Following are failing for some seemingly unrelated reason:

• ci/prow/v4.14-kuttl-parallel — Job failed.
• ci/prow/v4.14-kuttl-sequential — Job failed.

/retest

[olivergondza]

/retest-required

[olivergondza]

/retest

[olivergondza]

/retest

[olivergondza]

/retest

[olivergondza]

/retest

[olivergondza]

@varshab1210, can you please review? Thanks!

[AdamSaleh]

Works against our flexy-installed testing clusters: https://gist.github.com/AdamSaleh/8efda456af51c2ddb0eddff4f1a75070

[varshab1210]

Thanks @olivergondza @AdamSaleh /lgtm /approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: varshab1210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [varshab1210]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

New changes are detected. LGTM label has been removed.

[olivergondza]

Thanks for the review and verification, @AdamSaleh and @varshab1210.

Do you target particular time window to get this integrated? I would love to have this part of the next QE cycle...

New changes are detected. LGTM label has been removed.

Rebase to make things mergable. No new changes...

[varshab1210]

/retest

[openshift-ci[bot]]

@olivergondza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.17-ci-index-gitops-operator-bundle	66e908548f9af58c7d7066865098fbfff8468357	link	true	/test v4.17-ci-index-gitops-operator-bundle
ci/prow/v4.17-kuttl-sequential	66e908548f9af58c7d7066865098fbfff8468357	link	true	/test v4.17-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[varshab1210]

/retest

[olivergondza]

Gentle ping